[#9151] - Client/MenuType selector in Menu and Modules administrator list views (mobile xs)
- Closed
- 19 Feb 2016
- Medium
- Build: staging
- # 9151
- Diff
- andrepereiradasilva:menu-modules-views-mobile-xs-selector
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR solves #9031.
How to test
- Install latest staging
- Go to com_menus items view or com_modules modules view and reduce the browser width so you be in mobile xs size.
- How will see that the selector (client or menutype, depending on the view) disappeared
- Apply this patch
- Repeat 2 and 3 you will see now the selector (client or menutype, depending on the view) is there.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
@brianteeman i forgot to say but i also added jquery to reset the filter form when changing menutype (menu items) or client (modules). See https://github.com/andrepereiradasilva/joomla-cms/blob/menu-modules-views-mobile-xs-selector/administrator/components/com_menus/models/forms/filter_items.xml#L8
Please check that too.
oh - not sure I like that.
My view has, for UX, to maintain the same behavior when using a view selector. "Location" in several views and "MenuType" in menu items view.
For "Location" (Site/Admin) IMHO it make sense to reset all the filters, not entirety sure that is useful in the case of the menu items "MenuType".
I can remove it if you guys prefer.
Can you remove it from this PR and propose it in a new pr on its own. For
me it would be very annoying if I have set the menu to display 1 max level
for me to switch menu and have to do that all over again. Others may
disagree but i really feel it is out of scope of this PR
On 18 February 2016 at 17:13, andrepereiradasilva notifications@github.com
wrote:
My view has, for UX, to maintain the same behavior when using a view
selector. "Location" in several views and "MenuType" in menu items view.For "Location" IMHO it make sense, not entirety sure that is useful in the
case of the menu items types.I can remove it if you guys prefer.
—
Reply to this email directly or view it on GitHub
#9151 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.
Done. Reseted to previous behaviour.
I have tested this item 
successfully on 761925a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.
I have tested this item successfully on 761925a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.
| Status | Pending | ⇒ | Ready to Commit |
RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.
| Labels |
Added:
?
|
||
Merged - thanks!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-19 01:15:32 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 964c9e2
Perfect - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9151.