? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
18 Feb 2016

This is an old issue. Got even more obvious since was implemented in staging #9126

Test instructions:
Install multiple languages.
Set your admin user to use Default language for Administration
Go to the Installed languages page.
Change the default Administration Language to another language.

Results
The success message will be displayed in the former administration language, NOT the new changed one.
I.e. if the displayed language was English (en-GB) and you set default language to French, the success message will be the en-GB one.

Same issue with the new "Switch Language" feature.

This PR loads the new Administrator Language BEFORE sending the success message.

Now we get:
when default language was en-GB and one changes Default to French:
screen shot 2016-02-18 at 14 36 50

When using Switch ( I have updated the fr-FR.com_languages.ini file to Include the new success string)
screen shot 2016-02-18 at 14 40 16

@brianteeman @richard67 @andrepereiradasilva @gwsdesk @MATsxm
Thank you for testing

avatar infograf768 infograf768 - open - 18 Feb 2016
avatar infograf768 infograf768 - change - 18 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 18 Feb 2016

works perfectly for switching admin language
BUT
if i change the default site language it also works there which i don't think is a good idea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar infograf768
infograf768 - comment - 18 Feb 2016

Oopss, yep, it has to be limited in the case of default to administrator client. On it.

avatar infograf768
infograf768 - comment - 18 Feb 2016

Done.

avatar brianteeman brianteeman - test_item - 18 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Feb 2016

I have tested this item :white_check_mark: successfully on 4635737


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar andrepereiradasilva andrepereiradasilva - test_item - 18 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Feb 2016

I have tested this item :white_check_mark: successfully on 4635737


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Feb 2016

I have tested this item :white_check_mark: successfully on 4635737


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar brianteeman brianteeman - change - 18 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 18 Feb 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2016
Labels Added: ?
avatar MATsxm MATsxm - test_item - 18 Feb 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 18 Feb 2016

I have tested this item :white_check_mark: successfully on 4635737

I'm a bit late on this one but works as expected - Thanks Jean-Marie


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9150.

avatar wilsonge wilsonge - change - 19 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-19 01:28:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 19 Feb 2016
avatar wilsonge wilsonge - reference | 521b0fc - 19 Feb 16
avatar wilsonge wilsonge - merge - 19 Feb 2016
avatar wilsonge wilsonge - close - 19 Feb 2016
avatar wilsonge wilsonge - change - 19 Feb 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 19 Feb 2016

Merged - thanks guys!

Add a Comment

Login with GitHub to post a comment