? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
16 Feb 2016

Description

When you have a searchtools filter already selected and them you select another filter (or other option in the same filter), the pages reloads and there is a flickering of the searchtools (starts as hidden and them appears again).

This PR solves that by showing the searchtools filter bar with css (not waiting for js domready or onload) in the cases that there are active filters.

Before PR (click to open gif on new window - note there is flickering on filter changed)

before-pr

After PR (click to open gif on new window - note there is NO flickering on filter changed)

after-pr

How to test

  1. Install latest staging.
  2. Go to a view with a lot of filters (e.g. modules, content, menus, etc)
  3. Select a filter. Now selected another filter. You will see the flickering (starts as hidden and them appears again).
  4. Apply this patch
  5. Do the same as 2 and 3. No flickering now.

Test with several browsers (mobile / non mobile).
Test in several views (frontend / administrator).

Note: I don't know for sure if flickering is the right english word for this, if not please correct me.

Update: uploaded animated gif with screen capture to show what i mean.

avatar andrepereiradasilva andrepereiradasilva - open - 16 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Added: ?
avatar richard67 richard67 - test_item - 16 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 16 Feb 2016

I have tested this item :white_check_mark: successfully on fdbff67

Tested several backend views with Firefox and Microsoft Edge, both latest versions, on desktop.

Did not test mobile or frontend views.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9135.

avatar grhcj grhcj - test_item - 16 Feb 2016 - Tested successfully
avatar grhcj
grhcj - comment - 16 Feb 2016

I have tested this item :white_check_mark: successfully on fdbff67

Tested in frontend / backend, with firefox / ms edge and with different window sizes.
@andrepereiradasilva thanks for this!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9135.

avatar grhcj
grhcj - comment - 16 Feb 2016

@andrepereiradasilva Just tested this on mobile; the "Search tools" button isn't shown.
This happened on 2 views in the background I have tested.
I happens with and without the patch, so the patch is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9135.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

yes the search tools is hidden on mobile.
I think who did that was thinking in saving space on mobile view. I agree.

avatar brianteeman brianteeman - change - 16 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 16 Feb 2016

Setting RTC

Note: I don't know for sure if flickering is the right english word for this, if not please correct me.

https://en.wikipedia.org/wiki/Flash_of_unstyled_content


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9135.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - reference | 984544a - 18 Feb 16
avatar wilsonge wilsonge - merge - 18 Feb 2016
avatar wilsonge wilsonge - close - 18 Feb 2016
avatar wilsonge wilsonge - change - 18 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-18 01:03:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 18 Feb 2016
avatar wilsonge wilsonge - change - 18 Feb 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 18 Feb 2016

Add a Comment

Login with GitHub to post a comment