? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 Feb 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the search tools (filter, order, etc) to com_cache cache view.

Before PR

image

After PR

image

How to test

  1. Install latest staging
  2. Go to System -> Global configuration and enable some type of caching
  3. Naviagt in the backend and in the frontend
  4. Go to System -> Clear Cache, you will see some cached items in "site" and in "administrator"
  5. Apply this PR
  6. Go to System -> Clear Cache
  7. Test the new searchtools (search, filter, client selector, ordering, pagination)
avatar andrepereiradasilva andrepereiradasilva - open - 14 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2016
Labels Added: ? ?
avatar richard67
richard67 - comment - 14 Feb 2016

@andrepereiradasilva I just tested this and everything works except of the search box: Whatever I type in and enter, I always see all cache groups in the list and no message that no records found in case if I type in some stuff which should not be found. What shall it be good for? To search for a cache group name? Currently it seems to be good for nothing and have no effect. Do we really need a search box here?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar ghazal ghazal - test_item - 14 Feb 2016 - Tested successfully
avatar ghazal
ghazal - comment - 14 Feb 2016

I have tested this item :white_check_mark: successfully on d09486f

Works as expected except the search box as Richaerd67 mentionned.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar ghazal
ghazal - comment - 14 Feb 2016

@andrepereiradasilva
And a huge thanks for all your work.

avatar richard67 richard67 - test_item - 14 Feb 2016 - Tested unsuccessfully
avatar richard67
richard67 - comment - 14 Feb 2016

I have tested this item :red_circle: unsuccessfully on d09486f

Search box does not work, see my previous comment and confirmation of this in test result from @ghazal.

Everything else works.

Setting my test result to not successful so @andrepereiradasilva is able to check this before someone else sets a test result to success and we get a (too early) RTC here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Feb 2016

ups, thanks. forget to check that, will check when i have time.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Feb 2016

This PR has received new commits.

CC: @ghazal, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar richard67 richard67 - test_item - 14 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 14 Feb 2016

I have tested this item :white_check_mark: successfully on 5f391b9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar ghazal ghazal - test_item - 15 Feb 2016 - Tested successfully
avatar ghazal
ghazal - comment - 15 Feb 2016

I have tested this item :white_check_mark: successfully on 5f391b9

Search box OK.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar brianteeman brianteeman - change - 15 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 15 Feb 2016

Thanks for testing - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9121.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-18 19:42:05
Closed_By wilsonge
avatar wilsonge wilsonge - reference | c899d8a - 18 Feb 16
avatar wilsonge wilsonge - merge - 18 Feb 2016
avatar wilsonge wilsonge - close - 18 Feb 2016
avatar wilsonge wilsonge - change - 18 Feb 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 18 Feb 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment