[#9120] - Regression: Correct Modules ordering on drag and drop
- Closed
- 14 Feb 2016
- Medium
- Build: staging
- # 9120
- Diff
- andrepereiradasilva:com_modules-position-ordering
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
Modules should be ordered by their order in the position, so when we order using drag and drop we should get only enabled the modules in the same position.
That is not happening right now, the enabled modules on drag are the ones with the same "ordering" indepedent of the position.
Before PR
After PR
How to test
- Install latest staging
- Create some modules in the same position
- Try to order them within the position in the list view with drag and drop
- Apply this PR
- Try to order them now within the position in the list view with drag and drop
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Wow ... it seems people not use the drag and drop sorting so often (like me), or they accepted the bug as desired behavior ... otherwise the issue tracker should be full of it, or not? 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
Edit:
sorry , i'm sleeping. Ignore my past comments.
It's a recent problem.
@andrepereiradasilva what happens if you revert it back to position? 06f0d96#diff-bbb8ae0595d2d0e10b67b23fd3d1e670R96
Ahh, yes that's why I changed it in the first place
This PR has received new commits.
CC: @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
I have tested this item 
successfully on 6d80a0f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
I have tested this item successfully on 6d80a0f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit | ||||
| Title |
|
||||||
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-14 19:11:13 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@infograf768 @richard67 thanks for testing.
| Milestone |
Added: |
||
@wilsonge Somehow the issue tracker shows this as "new" in the list now, and not as closed. Am I just to impatient? Sorry if so.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
Ah, now it is ok.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.
I have tested this item
successfully on 95e56b4
I can confirm the bug, and I can confirm that this PR solves it.
@andrepereiradasilva Since this somewhen in past has worked as far as I remember, it very likely is a regression. Maybe you should mark this PR as such, e.g. by starting the title with [Regression], so maintainers can see quickly that is has to go into 3.5.0.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9120.