[#9118] - com_installer update view: searchtools ordering and some improvements
- Closed
- 19 Feb 2016
- Medium
- Build: staging
- # 9118
- Diff
- andrepereiradasilva:com_installer-updates-searchtools
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_installer update view.
Also:
- rearrange columns (install type moves to end)
- corrects bug where the folder filter has not selecting the search button
- corrects bug where by searching or selecting a filter the search tools resets when it should show the selected option
- correct visual on mobile, tablet and desktop
- other small graphical issues.
Before PR
After PR
How to test
- Install latest staging and apply this patch
- Install some old version extensions (which already have updates)
- Go to Extensions -> Manage -> Update
- Click "Find Updates" (check the updates for the extensions you installed are there)
- Check the search, ordering select box and the filter are working fine.
- Test desktop, tablet and mobile view (ex: reduce browser width).
- Update your extensions and check if are ok.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
I tested this with the extensions shown in the screenshot. When I tried to install both at once (select both -> install) I get this error:
Fatal error: Cannot redeclare class PlgSystemNoNumberInstallerInstallerScript in [...]\joomla\htdocs\tmp\install_56c1dc94b2ddd\script.install.php on line 15
Only the "What? Nothing" extension was updated.
When I try to install the cache cleaner extension alone, I get a warning:
Warning: JInstaller: :Install: Can't find XML setup file.
Because I think that it's my mistake, I don't mark my test results here. Maybe someone can check this.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
I expierenced the same problem as #grhcj when I tried to update more than one nonumber extension at once. But this behaviour is shown also without this patch. #Nonumber can you please have a look at this.
All other extensions where updated at one stroke. When I choose location ascending as sort order, 'site' comes before 'administrator', which is not alphabetically. But this beviour also existed before.
This PR has received new commits.
CC: @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
all ordering should work properly now, and in any language.
This PR has received new commits.
CC: @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
I have tested this item 
successfully on d54ff99
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
I have tested this item successfully on d54ff99
Successs. All works like before plus the sorting by the location is alphabetic now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Setting RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-19 01:24:06 |
| Closed_By | ⇒ | wilsonge |
Merged - thanks!
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
This has broken correct update proposals in Control Panel.
I have a component com_localise which is set as 4.0.13-dev (modified, this is why I do not update to the available 4.0.14-dev).
It now displays also as a Joomla Update.
Clicking on "Update Now" will load the Joomla Update page where, evidently, no update is proposed.
The Extensions:Update page correcty displays the possible update for the component.
Hmm, I had to clear the Update cache and then click on Find Updates to get rid of this error.
I am afraid that people updating to 3.5.0 would get the same issue. Any possible solution?
I have tested this item
successfully on c941ffe
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9118.