? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
13 Feb 2016

Remove comma if style is not set

See #9116

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

92ae51f 13 Feb 2016 avatar dgt41 Comma
avatar dgt41 dgt41 - open - 13 Feb 2016
avatar dgt41 dgt41 - change - 13 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2016
Labels Added: ?
avatar UncleR UncleR - test_item - 13 Feb 2016 - Tested unsuccessfully
avatar UncleR
UncleR - comment - 13 Feb 2016

I have tested this item :red_circle: unsuccessfully on 92ae51f

After chosing a module nothing happened. Returning to the editor was only possible with the close-Button of the selection window.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar richard67 richard67 - test_item - 14 Feb 2016 - Tested unsuccessfully
avatar richard67
richard67 - comment - 14 Feb 2016

I have tested this item :red_circle: unsuccessfully on 92ae51f

Same as for @UncleR , it worked before this patch.

Following error is reported in browser console:

TypeError: jQuery(...).val(...) is undefined

if (jQuery("#extra_class").val().length)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar richard67
richard67 - comment - 14 Feb 2016

@dgt41 See dgt41#29 for the correction :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar richard67
richard67 - comment - 14 Feb 2016

@dgt41 Sorry, with my PR dgt41#29 mentioned above it also does not work. The Javascript error is solved, but the value of the extra class input field is never used with it. I try to find a solution but am neither a Javascript nor a jQuery expert.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar richard67
richard67 - comment - 14 Feb 2016

@dgt41 I have just commited a change to my PR dgt41#29 for you, and now all works, just have tested. So if you accept my PR this PR here can be tested with success.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Feb 2016

This PR has received new commits.

CC: @richard67, @UncleR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Feb 2016

This PR has received new commits.

CC: @richard67, @UncleR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar dgt41
dgt41 - comment - 14 Feb 2016

@richard67 thanks, of the patch, I've simplified these lines a bit more

avatar richard67 richard67 - test_item - 14 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 14 Feb 2016

I have tested this item :white_check_mark: successfully on 29f9e6b

Tested with success.
Extra style parameter is added to the loadmodule or loadposition call at the end, separated by a comma, if set in the input box, otherwise if no extra style then no parameter and no comma added.
Examples:
{loadmodule mod_languages,Language switcher}
{loadmodule mod_languages,Language switcher,dada}
{loadposition position-0}
{loadposition position-0,dada}


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar viocassel
viocassel - comment - 14 Feb 2016

I have tested this item :white_check_mark: successfully on 29f9e6b

Everything works fine.

avatar UncleR UncleR - test_item - 14 Feb 2016 - Tested successfully
avatar UncleR
UncleR - comment - 14 Feb 2016

I have tested this item :white_check_mark: successfully on 29f9e6b

OK.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar brianteeman brianteeman - change - 15 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Feb 2016

Thanks for testing - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2016
Labels Added: ?
avatar roland-d roland-d - close - 16 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Feb 2016
avatar roland-d roland-d - change - 16 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-16 17:29:26
Closed_By roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment