Language Change PR-staging

Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
13 Feb 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_installer discover view.

Also:

  • now discovers the extensions by default onload (if not discovered before).
  • the columns were reordered to match the "Manage" view.
  • corrects bug where the folder filter has not selecting the search button, and other small graphical issues.
Before PR

image

After PR

image

How to test

  1. Install latest staging and apply this patch
  2. Go to the database "prefix_extensions" table and delete the "beez3" and "hathor" rows (or other if you want).
  3. Go to Extensions -> Manage -> Discover (you will see hathor and beez3 there)
  4. Check the search, ordering select box and the filter are working fine.
  5. Test desktop, tablet and mobile view (ex: reduce browser width).
  6. Install hathor and beez here and check if ok.
avatar andrepereiradasilva andrepereiradasilva - open - 13 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 13 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2016
Labels Added: Language Change PR-staging
avatar andrepereiradasilva andrepereiradasilva - change - 13 Feb 2016
The description was changed
avatar richard67 richard67 - test_item - 13 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 13 Feb 2016

I have tested this item :white_check_mark: successfully on c42375c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar grhcj grhcj - test_item - 15 Feb 2016 - Tested successfully
avatar grhcj
grhcj - comment - 15 Feb 2016

I have tested this item :white_check_mark: successfully on c42375c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar brianteeman brianteeman - change - 15 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman brianteeman - change - 15 Feb 2016
Title
com_installer discover view: searchtools ordering and some improvements
com_installer discover view: searchtools ordering and some improvements
avatar brianteeman
brianteeman - comment - 15 Feb 2016

RTC - thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2016
Labels Added: RTC
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

This one needs similiar changes like the ones made yesterday in #9118.

This changes can solve the problem with translatable columns results (Location, Type and Folder). They are incorrected sorted in some languages (depending on the translation), also, location is always incorrected sorted because as it is now is sorting by client id, not the client translate text.

This problem existed before this PR, but i think i can solve this in this PR too if you guys are willing to test again after the changes.

avatar richard67
richard67 - comment - 16 Feb 2016

@andrepereiradasilva If I have time I am willing to test again, sure. But this PR is already RTC, so it might get merged before you can provide the changes. In this case, if you make a new PR then, let me know here so I find it and can help with testing.

avatar grhcj
grhcj - comment - 16 Feb 2016

@andrepereiradasilva Please let me know me when you changed this behaviour.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Feb 2016

This PR has received new commits.

CC: @grhcj, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Feb 2016

This PR has received new commits.

CC: @grhcj, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

@richard67 @grhcj ok, should be good now, please retest.

A change like this is also needed in com_installer manage and updatesites view, but that's a new PR.

Please test in another language too, like german for instance.

avatar richard67
richard67 - comment - 16 Feb 2016

I go sleep now, I'll test tomorrow if still necessary then. Good night.

avatar richard67 richard67 - test_item - 17 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 17 Feb 2016

I have tested this item :white_check_mark: successfully on d14ddda

Works still as desired plus sorting by Location is alphabetic now, tested English, German (which is same as English at this point and so not a good example for this test) and Russian (for which I could look up the alphabet at Wikipedia, I do not understand Russian).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Feb 2016

@richard67 when i say German is because the "Type" column. Although it seems is correctly ordered before this last change, it isn't.

It's true that in com_installer discover view is not easy to check (you would have to have a lot of discovered extensions of several types).

But you can see what i mean by going to manage (or update sites) view. In the "Type" column "Library" in english is "Bibliothek" in german so should be ordered in a different way.

Either way thanks for the test.

avatar richard67
richard67 - comment - 17 Feb 2016

@andrepereiradasilva Ok, thanks for the clarification. I have repeated my test with extensions of diverse type and can confirm that the Type column is now sorted alphabetically while before it was not, so my successful test result is still valid.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar grhcj grhcj - test_item - 17 Feb 2016 - Tested successfully
avatar grhcj
grhcj - comment - 17 Feb 2016

I have tested this item :white_check_mark: successfully on d14ddda

Still works as expected (in desktop, tablet and mobile view).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9114.

avatar wilsonge wilsonge - change - 19 Feb 2016
Milestone Added: Joomla! 3.5.0
avatar wilsonge
wilsonge - comment - 19 Feb 2016

Merged - thanks!

avatar wilsonge wilsonge - change - 19 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-19 01:27:25
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 19 Feb 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: RTC

Add a Comment

Login with GitHub to post a comment