[#9093] - Adds jlayout searchtools to com_users user groups
- Closed
- 16 Feb 2016
- Medium
- Build: staging
- # 9093
- Diff
- andrepereiradasilva:user-groups-searchtools
- Success Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR adds, for consistency, as it exists in so many other views in the backoffice, the search tools to com_users user groups.
As an extra also added a badge and a link in the number of users in that group.
Before PR
After PR
How to test
- Install latest staging and apply this patch
- Go to Users -> User Groups
- Check the ordering select box and search is working fine.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
@ghazal please mark tested in https://issues.joomla.org/tracker/joomla-cms/9093 (after login the Test button appears). See https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results
I have tested this item 
successfully on 6aa24ec
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9093.
thanks
I have tested this item 
unsuccessfully on 6aa24ec
Column for ordering is not shown (and was not shown before this patch), so the ordering should not be among the sorting options, and so it should not be the default option.
So either the default sorting should be changed to something else than ordering, and ordering should be removed from the sorting options, or a column for the ordering should be shown.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9093.
@richard67 i asked myself that in this one.
I decided to not change the default ordering (from Public to Super User) because people are used to that.
A ordering (e.g. drag and drop) behaviour for this view does not exist before and after the PR.
Please notice that before this PR the issue you described exists. This PR has not changed that.
So i didn't change the behaviour of this view, so in my understand your test of the changes made in this PR is successfully.
I suppose a new PR should be made to add ordering columns and behaviour to groups, if it makes sense at all.
I have tested this item successfully on 6aa24ec
I am convinced now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9093.
I have tested this item successfully on 6aa24ec
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9093.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9093.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-16 13:44:06 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
Test OK.
(PHP7).