[#9049] - Fix Drag&Drop sorting
- Closed
- 16 Feb 2016
- Medium
- Build: staging
- # 9049
- Diff
- renekorss:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix sorting if there is items with different heights. Bug occured only for moving higher item up. Now respects height of moved item.
fixes #8861
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@brianteeman You created on article with very long title and moving it up results in ordering 1, 2, 3? Not 1, 1, 3?
Yes and Yes
After playing a bit more and doublechecking with the database entries I was able to get it to misbehave once - where the DB entry did not match the visual display.
I applied the patch and retested and couldnt replicate the bug anymore so this is a good test
| Category | ⇒ | JavaScript |
| Rel_Number | 0 | ⇒ | 8861 |
| Relation Type | ⇒ | Pull Request for |
To anyone else testing make sure you check the value of the ordering column in the database
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
@svenbluege Please mark test results on https://issues.joomla.org/tracker/joomla-cms/9049
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
I have tested this item 
successfully on 4b8325e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
@wojsmol Done. First time for me so let me know if there is more todo.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
@svenbluege Now everything is correctly.
I have tested this item successfully on 4b8325e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
| Labels |
Added:
?
|
||
@renekorss There are conflicts here - can you please fix them :) If not then to confirm https://github.com/joomla/joomla-cms/pull/9049/files#diff-0f3028a8e62b1bde4dd60f2a5af107b0R225 is the only line that has changed right?
This PR has received new commits.
CC: @brianteeman, @svenbluege
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.
roland-d
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-16 17:35:01 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I can not replicate this issue