Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8991] - com_wrapper auto-height error in IE

? Pending
Pull Request for # 8989

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
26 Jan 2016

fix for #8989
Original issue description

javascript code in /media/com_wrapper should have

document.frames['blockrandom'].document.body.scrollHeight

but not

document.frames('blockrandom').document.body.scrollHeight

Note that auto-height actually works for IE only.

avatar wojsmol wojsmol - open - 26 Jan 2016
avatar wojsmol wojsmol - change - 26 Jan 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 27 Jan 2016
Rel_Number 0 ⇒ 8989
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 27 Jan 2016
Category ⇒ JavaScript
avatar Denitz
Denitz - comment - 27 Jan 2016

Hm.. after tests I found the better code which works for IE, Chrome and Firefox:

function iFrameHeight()
{
    if (window.frames && window.frames['blockrandom'])
    {
        var doc = window.frames['blockrandom'].contentDocument || window.frames['blockrandom'].document || window.frames['blockrandom'].contentWindow.document;
        if (doc !== undefined) {
            document.getElementById('blockrandom').style.height = parseInt(doc.body.scrollHeight) + 20 + 'px';
        }
    }
}
avatar brianteeman
brianteeman - comment - 8 May 2016

@Denitz Can you please submit a PR with that code

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8991.

avatar wojsmol
wojsmol - comment - 8 May 2016

@brianteeman Code proposed by the @Denitz in #8991 (comment) I added in f9cb8fd

avatar brianteeman
brianteeman - comment - 8 May 2016

Thanks - I can see that now on github.com but the issue tracker didnt show that ;(

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8991.

avatar conconnl
conconnl - comment - 2 Jul 2016

Is this ready for testing?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8991.

avatar wojsmol
wojsmol - comment - 3 Jul 2016

yes

avatar kevinscheithauer
kevinscheithauer - comment - 2 Aug 2016

Can you please provide some test instructions? I have trouble finding out what this is suppposed to fix. I tried some things with a wrapper in IE but it didnt seem to change anything.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8991.

avatar schmidtpaddy schmidtpaddy - test_item - 2 Aug 2016 - Tested successfully
avatar schmidtpaddy
schmidtpaddy - comment - 2 Aug 2016

I have tested this item ✅ successfully on f9cb8fd

tested in edge. changes were made. @icampus

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8991.

avatar mcanuste mcanuste - test_item - 2 Aug 2016 - Tested unsuccessfully
avatar mcanuste
mcanuste - comment - 2 Aug 2016

I have tested this item ? unsuccessfully on f9cb8fd

Tested @icampus
After PR:
Console shows this error on IE version 11.

avatar Denitz
Denitz - comment - 3 Aug 2016

@mcanuste What is iframe URL? Ensure that same-origin policy is respected.

avatar slibbe slibbe - test_item - 4 Nov 2016 - Tested unsuccessfully
avatar slibbe
slibbe - comment - 4 Nov 2016

I have tested this item ? unsuccessfully on f9cb8fd

I'm with kevinscheithauer. I could not reproduce this issue; maybe someone can write more precise test instructions?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8991.

avatar slibbe
slibbe - comment - 4 Nov 2016

I'm with kevinscheithauer. I could not reproduce this issue; maybe someone can write more precise test instructions?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8991.

avatar microtribe microtribe - test_item - 13 Nov 2016 - Tested unsuccessfully
avatar microtribe
microtribe - comment - 13 Nov 2016

I have tested this item ? unsuccessfully on f9cb8fd

Like others I think we need better instructions to recreate the issue. I created a new menu item wrapper with auto-height set, and it displayed exactly the same in Chrome and IE 11.09600.18499

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8991.

avatar jeckodevelopment
jeckodevelopment - comment - 20 Nov 2016

@wojsmol can you please look at the conflicts?

avatar wojsmol
wojsmol - comment - 20 Nov 2016

@jeckodevelopment fixed with #11554

avatar wojsmol wojsmol - change - 20 Nov 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-20 15:04:37
Closed_By ⇒ wojsmol
avatar wojsmol wojsmol - close - 20 Nov 2016

Add a Comment

Login with GitHub to post a comment