[#8985] - 2 suspicious code fragments
- Closed
- 4 Aug 2016
- Medium
- Build: staging
- # 8985
- Diff
- AppChecker:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
1) It looks strange that $htmlPath is checked twice. It seems that another variable should be checked instead, possibly $overridePath.
2)
Both parts of ternary operation are identical.
return ($show_encrypt) ? '{SHA256}' . $encrypted : '{SHA256}' . $encrypted;
It seems that it should be like this:
return ($show_encrypt) ? '{MD5}' . $encrypted : $encrypted;
Possible defect was found by AppChecker static analyzer (http://cnpo.ru/en/solutions/appchecker.php).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | ⇒ | Libraries |
Yeah, I agree with @wilsonge here. Could you update the pull request please?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8985.
It's six months since @wilsonge made his comment so it's highly unlikely @AppChecker is going to do that. Best to do a new pr yourself. My 2c
| Category | Libraries | ⇒ | Administration Components Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-04 07:22:30 |
| Closed_By | ⇒ | roland-d | |
| Rel_Number | 0 | ⇒ | 11433 |
| Relation Type | ⇒ | Related to |
I am closing this pull request as we have a replacement at #11433 Thank you for your contribution.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8985.
First one seems like a sensible change. The second one (despite being a bug) I'm tended towards leaving "open". the sha hashes were only used in a very small number of Joomla installs in a limited number of Joomla 3.2 versions. Fixing that bug might well do more harm than good.