If I understand correctly this is only useful in a site running partially
on http and partially on https.

As the current recommendation is to run a site on https only what is the
benefit of this PR?
On 26 Jan 2016 8:49 am, "Thomas Kuschel" notifications@github.com wrote:

Add a Security Field inside the Metadata of the Menu Item Type "Menu Item
Alias", as well as in the standard "Menu Item".
Problem:
Preconditions: Website have to support both http and https
1.) Create a Menu Item "A" (e.g. inside a Menu location which is hidden on
the template) to a component with the following additional settings:
a) Metadata Options
Secure : On
b) Access: Registered
that should switch the menu link from unsecure http to secure https
connection.
2.) Create a Menu Item "B" in the Main Menu with the Menu Item Type "Menu
Item Alias" and pointing to the Menu Item which was created before.
There is no "Metadata Options" for the "Menu Item Alias"
3.) You are not logged-in; and you are also switch to unsecure http://
4.) Clicking to the Menu "B" opens a login-Window but without https

connection, only http!

You can view, comment on, or merge this pull request online at:

#8984
Commit Summary

• Security Field for Menu Item Alias

File Changes

• M administrator/components/com_menus/models/forms/item_alias.xml https://github.com/joomla/joomla-cms/pull/8984/files#diff-0 (12)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/8984.patch
• https://github.com/joomla/joomla-cms/pull/8984.diff

—
Reply to this email directly or view it on GitHub
#8984.

Hi brianteeman,
I support a website which has to be both https and http (for an access of clients which only supports http - special hardware). So I need this field to switch security on some menu items. I already used this since 2 years with Joomla 2.5; and there is no other workaround. Nevertheless, the normal Menu Item has this built-in feature, to manually switch to security https (or unsecurity http, or ignore).
On a site with https only, there is no need to switch b/w http and https.
Thomas

I have tested this item successfully on 7ba94f7

Test OK. Quite handy!

This PR has received new commits.

CC: @anibalsanchez

How does this Pull Request merge into the joomla-cms, is there anything I can do for it?

• I need this feature; and it's IMHO usefull: *) Having a site with many "registered only menus" using alias menus to show the menu also for non-registered users.

Before a Pull Request can be merged it needs at least two successful tests

Thank you very much, IMHO it's not so an important feature, but pending since Jan 26. Hope it will be part sometime.

I have tested this item successfully on a53573f

Running since Joomla 2.5, about 2 years now, same in Joomla 3.x 1/2 year.
Does not effect any other menu b/c it is already part of standard menu item.

@tkuschel but you cant test your own code - its assumed you would only ever submit tested code.

I will try to get some people to test this at the joomladay in the netherlands on friday

I have tested this item successfully on a53573f

I tested this successfully, but in my opinion the menu item alias should take care of each setting from the item it refers to. No need to set it there once again?

I have tested this item successfully on a53573f

I have tested this patch succesfully. The logging in or not does not seem to make any difference for the test. I also agree with @designbengel that the desired setting should be taken over from the item that the alias is a copy off, no need to create new settings then.

I agree with @designbengel : the alias should append all settings from the menu item it is an alias of. Applying this patch makes it possible to set the secure setting different from the original, which is an (in my opinion) unwanted side-effect. It makes managing aliases more time-consuming and introduces the possibility to make unintended changes).

Based on the comments above I am setting this to Needs Review so the maintainers can make a decision

the menu item alias should take care of each setting from the item it refers to.
You are right - thanks designbengel; it would be better when the security setting is taken from the original menu item not from the alias itself. On the other hand, you can create two different alias one secure, the other unsercure or not.

sorry I pressed the wrong button, and closed / reopend the PR

Agree that in this case the alias should adopt the settings of the menu item it is pointing to. Closing as this PR does not address that issue.

Set to "closed" on behalf of @chrisdavenport by The JTracker Application at issues.joomla.org/joomla-cms/8984