Feeling Lucky
?
[#8967] - Change recaptcha default version to 2.0
- Closed
- 23 Jan 2016
- Medium
- Build: staging
- # 8967
- Diff
- n9iels:patch-1
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
On a new install, the default choose for the ReCAPTCHA plugin is version 1.0. But there is also a this warning:
You have selected Version 1.0. All new sites should be using Version 2.0. Version 1.0 is only maintained to provide support for Global Site keys which are no longer available from Google.
So why we don't change the default to version 2.0?
Or was there a certain reason that version 1.0 is still default?
Test instructions
- Go to Plugins -> Recaptcha (make sure you didn't save the plugin before. If you did, clean the parameter field in the database)
- Notice that version 1.0 is default select
- Apply patch and notice that 2.0 is now default selected
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
infograf768
- comment
- 23 Jan 2016
There was a good reason for that default. If a user has already Global Keys, it would look like Joomla is the responsible for breaking recaptcha.
Read #5888 (comment)
I suggest to close this PR.
andrepereiradasilva
- comment
- 23 Jan 2016
i think you should also change all the:
$this->params->get('version', '1.0')tp
$this->params->get('version', '2.0')in https://github.com/joomla/joomla-cms/blob/staging/plugins/captcha/recaptcha/recaptcha.php
n9iels
- comment
- 23 Jan 2016
Ah, that was the reason. Makes sense now. Thanks, I will close this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-23 09:57:55 |
| Closed_By | ⇒ | n9iels |
I have tested this item
successfully on 5fd037e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8967.