[#8966] - Only access appscdn.joomla.org over ssl/https
- Closed
- 31 Jan 2016
- Medium
- Build: staging
- # 8966
- Diff
- PhilETaylor:InstallFromWebOverSSL
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The current method connects to http://appscdn.joomla.org/webapps/jedapps/webinstaller.xml
If your site is currently configured over a SSL/https url then the "Add from web" installer no longer loads due to the security of modern web browsers
This changes the url to use the https://appscdn.joomla.org/webapps/jedapps/webinstaller.xml url - note the S in the protocol is the only thing changing
Without this change you get these kind of issues:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
The install from web plugin never got a release -.- are we sure this is going to work without that being updated in the plugin?
Yes it works, I have had to change it on two websites today including the one in the screenshot .., but let someone test it - maybe @brianteeman as I note he has his site on ssl/https now...
Test in structions:
- find your ssl powered Joomla site
- Login to Joomla Admin -> install the install from web plugin on the install extensions page
- Note that it installs ok, but doesnt load the content of the tab
- apply PR
- note it works now..
Install plugin
Loading - wait
Fail with
Can't connect to the Joomla! server. Please try again later.
Apply patch
Loading - wait
Fail with
Can't connect to the Joomla! server. Please try again later.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8966.
haha so its broken before you patched haha - are you sure the patch applied? are you sure your "secure" webhost allows outgoing requests?
yes and no
On 23 January 2016 at 00:01, Phil Taylor notifications@github.com wrote:
haha so its broken before you patched haha - are you sure the patch
applied? are you sure your "secure" webhost allows outgoing requests?—
Reply to this email directly or view it on GitHub
#8966 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Any messages in Google Chrome @brianteeman ? (CMD+OPT+i)
Weird - need to double check the patch is being applied - patchtester says yes and never had an issue before but both before and aftr give
jquery.min.js:5 Mixed Content: The page at 'https://brian.teeman.net/administrator/index.php?option=com_installer' was loaded over HTTPS, but requested an insecure script 'http://appscdn.joomla.org/webapps/index.php?format=json&option=com_apps&vie…e=My40&dev_level=OA==&list=grid&pv=MS4wLjU=&callback=jedapps_jsonpcallback'. This request has been blocked; the content must be served over HTTPS.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8966.
indeed - doesnt look like the patch applied :)
It is applied as confirmed by screenshot
(time for bed)
Cache... Siteground... Clear.... ? Flush in SiteGround cPanel ? PHP OpCode Cache caches content of PHP files :)
all done
On 23 January 2016 at 00:11, Phil Taylor notifications@github.com wrote:
Cache... Siteground... Clear.... ? Flush in SiteGround cPanel ?
—
Reply to this email directly or view it on GitHub
#8966 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
ok I get it now
My change changes this url https://appscdn.joomla.org/webapps/jedapps/webinstaller.xml
which is the installer... to allow you to install the "install from web" plugin...
Your failing url is in the install from web plugin itself! which is the files
/administrator/components/com_installer/views/install/tmpl/default.php
/plugins/installer/webinstaller/webinstaller.php
/plugins/installer/webinstaller/webinstaller.xml
So this PR does all it can in this repo to be compatible with SSL Hosted Joomla sites... we did our bit this end, now the webinstaller plugin needs updating too...
No reason this cannot be merged though.
To confirm this PR addresses the INSTALLATION of the Install From Web plugin on a SSL Joomla site.
If you did want to use the install from web @brianteeman you would need to manually update those three files above on your site using FTP :) then you own site could see/use the install from web features.
hmmm I deleted the repo that this merge came from - does that mean it can no longer be merged and I have to do a new PR ?
It seems ok to me (as in the big green button still shows). but if you ever need to merge in staging then it will become a problem
I don't do the merging - you do :)
It not available in Patch Tester any more, it give a repository not found message :(
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-31 16:40:34 |
| Closed_By | ⇒ | wilsonge |
Merged on review. I can see the two XML files are valid over https
| Milestone |
Added: |
||
Note that this has already been updated in the install from web client ( https://github.com/joomla-extensions/install-from-web-client/blob/master/plugins/installer/webinstaller/webinstaller.php#L21) and so Joomla-cms should follow suit.