User tests: Successful: Unsuccessful:
I have created a pull request #8929 to remove the class "active" from the "you are here" text and leave it only on the menu item of the page you are on. The issue is explained better here. #8593 (comment)
After making this request I have updated the protostar template so the "you are here" text is still the same colour as previous.
The original change may break backwards compatibility with other templates.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
@infograf768 wouldn't that mean that the issue was template specific? The issue needs to be fixed for all templates and thus needs to be fixed in the core not as an override, or have I missed something?
@infograf768 If we apply override in the protostar then none of templates shipped with Joomla! will not show the appearance of mod_breadcrumbs based on https://github.com/joomla/joomla-cms/blob/staging/modules/mod_breadcrumbs/tmpl/default.php
Not sure I was understood.
I meant that #8929 is fine and should be merged at the same time as this PR.
For this PR I just suggested to make a full override for protostar instead of a css change to keep the display as it was.
If you really prefer the css change, it has to be done in the less file and then generated by generate.php.
Here is the diff:
diff --git a/templates/protostar/css/template.css b/templates/protostar/css/template.css
index 2f880bb..b5dc3fc 100644
--- a/templates/protostar/css/template.css
+++ b/templates/protostar/css/template.css
@@ -7127,4 +7127,7 @@
margin: 10px 0;
}
+.breadcrumb > li {
+ color: #999;
+}
.img_caption .left {
float: left;
diff --git a/templates/protostar/less/template.less b/templates/protostar/less/template.less
index cea47b3..b64b6c9 100644
--- a/templates/protostar/less/template.less
+++ b/templates/protostar/less/template.less
@@ -228,4 +228,7 @@
margin: 10px 0;
}
+.breadcrumb > li {
+ color: #999;
+}
/* Caption fixes */
.img_caption .left {
Sorry @infograf768 you are right, I had not understood. Please double check my amendment to the LESS file #8937. I have not removed the CSS addition, is this the best thing to do?
I assume that I do not need to update media/jui/less/breadcrumbs.less????
I'll show you a bit Eoin at the JUG - but you need to run a script as well. We'll do it in the LESS file
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-19 19:21:40 |
Closed_By | ⇒ | wilsonge |
@uglyeoin
That is not imho the way to do.
What should be done is adding a full override of the module in protostar/html/mod_breadcrumbs/ as default.php keeping it as it is in the original default.php before your changes.