? Success

User tests: Successful: Unsuccessful:

avatar uglyeoin
uglyeoin
18 Jan 2016

Removed the class="active" from line 17 which is text. In the standard Joomla! install it says "you are here". This should not be active, only the menu item for the page you are on should be active. You can see an example here: http://eoindemo.demojoomla.com/index.php/bread-crumbs-content

Issue posted here: #8593 (comment)

Protostar needs to be updated with this CSS

.breadcrumb > li {
color: #999;
}

This change may break backwards compatibility with other templates. I have fixed Protostar.

Protostar pull request here: #8930

avatar uglyeoin uglyeoin - open - 18 Jan 2016
avatar uglyeoin uglyeoin - change - 18 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2016
Labels Added: ?
avatar uglyeoin uglyeoin - reference | 975402f - 18 Jan 16
avatar wojsmol wojsmol - test_item - 18 Jan 2016 - Tested successfully
avatar wojsmol
wojsmol - comment - 18 Jan 2016

I have tested this item :white_check_mark: successfully on 21dba53

Together with PR #8930


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar wojsmol wojsmol - test_item - 18 Jan 2016 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 18 Jan 2016

@wojsmol thanks

avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Jan 2016

This PR has received new commits.

CC: @wojsmol


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Jan 2016

This PR has received new commits.

CC: @wojsmol


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar brianteeman brianteeman - test_item - 19 Jan 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Jan 2016

I have tested this item :white_check_mark: successfully on 540aa6e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar wojsmol wojsmol - test_item - 19 Jan 2016 - Tested successfully
avatar wojsmol
wojsmol - comment - 19 Jan 2016

I have tested this item :white_check_mark: successfully on 540aa6e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar brianteeman brianteeman - change - 19 Jan 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 19 Jan 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8929.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-19 21:59:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 19 Jan 2016
avatar wilsonge wilsonge - reference | 0eed608 - 19 Jan 16
avatar wilsonge wilsonge - merge - 19 Jan 2016
avatar wilsonge wilsonge - close - 19 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 19 Jan 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 19 Jan 2016

Merged - thanks @uglyeoin for your first PR! Look forward to seeing more!

Add a Comment

Login with GitHub to post a comment