Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8888] - Correct afterLoad time in Joomla Debug Console

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Jan 2016

Description

This PR corrects the afterLoad time and memory usage in the debugger Profile Information block.
As it is now Joomla is returning a not real page generation time because it's not counting the load time (files loaded in index.php or administrator/index.php).

Before PR:
image

After PR:
image

How to test

  1. Apply this patch.
  2. Turn on the debug in global config and the debug system plugin.
  3. Test any page in frontend or admin and check if the afterLoad time and memory usage is in the debugger Profile Information block.
avatar andrepereiradasilva andrepereiradasilva - open - 12 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 12 Jan 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 12 Jan 2016
Title
…
Debugger corret after load
Correct afterLoad time in Joomla Debug Console
avatar mbabker
mbabker - comment - 12 Jan 2016

The same should be done for the memory use.

On Tuesday, January 12, 2016, andrepereiradasilva notifications@github.com
wrote:

Description

This PR corrects the afterLoad time in the debugger Profile Information
block.
As Joomla is returning a not real page generation time because it's not
counting the load time (files loaded in index.php or
administrator/index.php).

Before PR:
[image: image]
https://cloud.githubusercontent.com/assets/9630530/12274224/d5204edc-b961-11e5-91f3-ce5c92365366.png

After PR:
[image: image]
https://cloud.githubusercontent.com/assets/9630530/12274371/801e5c84-b962-11e5-9d44-bbbb20fc7937.png
How to test

  1. Apply this patch.
  2. Turn on the debug in global config and the debug system plugin.
  3. Test any page in frontend or admin and check if the afterLoad time is in the debugger Profile Information block.

You can view, comment on, or merge this pull request online at:

#8888
Commit Summary

  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge branch 'staging' of https://github.com/andrepereiradasilva/joomla-cms into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into debugger-corret-after-load
  • correct afterLoad time
  • Improve comment

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#8888.

avatar andrepereiradasilva andrepereiradasilva - change - 12 Jan 2016
The description was changed
Title
…
Debugger corret after load
Correct afterLoad time in Joomla Debug Console
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Jan 2016

Done.

avatar alikon
alikon - comment - 16 Jan 2016

tested successfully

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Jan 2016

@alikon please mark as "Tested successfully" in "Joomla! Issue Tracker" https://issues.joomla.org/tracker/joomla-cms/8888 (after login the "Test this" button appears).
For more information see https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

avatar alikon alikon - test_item - 17 Jan 2016 - Tested successfully
avatar alikon
alikon - comment - 17 Jan 2016

I have tested this item :white_check_mark: successfully on 0fe9de3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8888.

avatar NLRoosj NLRoosj - test_item - 17 Jan 2016 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 17 Jan 2016

I have tested this item :white_check_mark: successfully on 0fe9de3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8888.

avatar roland-d roland-d - change - 17 Jan 2016
Milestone Added:
avatar 810
810 - comment - 17 Jan 2016

@test +1

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jan 2016

@810 please mark as "Tested successfully" in "Joomla! Issue Tracker" https://issues.joomla.org/tracker/joomla-cms/8888 (after login the "Test this" button appears).
For more information see https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

avatar 810 810 - test_item - 17 Jan 2016 - Tested successfully
avatar 810
810 - comment - 17 Jan 2016

I have tested this item :white_check_mark: successfully on 0fe9de3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8888.

avatar dgt41 dgt41 - change - 17 Jan 2016
Status Pending ⇒ Ready to Commit
avatar dgt41
dgt41 - comment - 17 Jan 2016

@joomla-bot wake up!

avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Added: ?
avatar joomla-bot
joomla-bot - comment - 17 Jan 2016

@joomla-bot wake up!

Please do not disturb my winter slumber. @joomla-cms-bot will assist you when it gets around to it. Thanks.

avatar dgt41
dgt41 - comment - 17 Jan 2016

@mbabker ????

avatar andrepereiradasilva andrepereiradasilva - reference | f6a23bf - 17 Jan 16
avatar wilsonge
wilsonge - comment - 17 Jan 2016

Merged with 8f7604b

avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-01-17 20:32:14
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - reference | 8f7604b - 17 Jan 16
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jan 2016

Add a Comment

Login with GitHub to post a comment