? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
12 Jan 2016

Executive summary

These change allows to count hits for an article also when cache is switched on

Backwards compatibility

Full b/c, no problems are expected

Translation impact

none

Why

If you switch cache on hits for an article are not counted right. The counter will be increased for the first time the article is requested. For the time the article come directly from the cache hits are not counted, this makes the statistic useless.

Testing instruction

To reproduce the error

  • Install a fresh version of Joomla
  • Create an article with an intro and full text, we need a read more button
  • Make it a featured article so that you can see the article on the home page
  • Notice that the counter is 0 (check this in the backend!)
  • Click on the read more button and go back
  • Notice that the counter is 1
  • Click again and go back
  • Counter === 2

  • Switch on cache

  • Click on the read more button and go back
  • Counter === 3
  • Click on the read more button and go back
  • Counter === 3 (ups)

You can now wait the cache time and click and the counter will increase. If you are not so patient you can clear the cache and click then and the counter will increase

Expected behavior

Every time you click on an article to counter should increase if cache is set on or off shouldn’t make a difference.

Apply patch and testing

  • Switch cache off
  • check the hit counter value => N
  • Click on the read more button and go back
  • Counter === N+1
  • Switch on cache
  • Click on the read more button and go back
  • Counter === N+2
  • Click on the read more button and go back
  • Counter === N+3

Bingo :-)

All counter checks should be made in the backend the frontend is caching values if caching is on.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar rdeutz rdeutz - open - 12 Jan 2016
avatar rdeutz rdeutz - change - 12 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2016
Labels Added: ?
avatar infograf768 infograf768 - change - 13 Jan 2016
Category Front End
avatar infograf768 infograf768 - test_item - 14 Jan 2016 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 14 Jan 2016

I have tested this item :red_circle: unsuccessfully on f8808d6

This did not work here.
I did not use the Read More, just re-loaded the article.
Before implementing Conservative Cache, all is fine. Hits are updated each time I load the article.
After, it is not updated, patched or not.
Hits are incremented OK in back-end.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8887.

avatar rdeutz
rdeutz - comment - 14 Jan 2016

@infograf768 and how did you load the article, when not with clicking the read more button?

avatar infograf768
infograf768 - comment - 14 Jan 2016

Just reloading the page. (cmd-R on Firefox Macintosh)

avatar Bakual
Bakual - comment - 14 Jan 2016

@infograf768 I'd say it's expected that the hit counter that is displayed in frontend is also cached and stays on the old value. If it does a jump to the correct value after cache is expired.then it's fine.

avatar infograf768
infograf768 - comment - 14 Jan 2016

@Bakual
If it is expected, then I do not see the value of this PR... See Tests instructions above.

avatar rdeutz
rdeutz - comment - 14 Jan 2016

The value of the PR is that it counts also when the cache is on, you need to check the count in the backend

avatar infograf768
infograf768 - comment - 14 Jan 2016

In that case, it is indeed working.
Please change test instructions.

avatar infograf768 infograf768 - test_item - 14 Jan 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 14 Jan 2016

I have tested this item :white_check_mark: successfully on f8808d6

Hits counter now works in back-end.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8887.

avatar rdeutz
rdeutz - comment - 14 Jan 2016

Changed Test instructions, thanks for testing @infograf768

avatar justinherrin justinherrin - test_item - 14 Jan 2016 - Tested successfully
avatar justinherrin
justinherrin - comment - 14 Jan 2016

I have tested this item :white_check_mark: successfully on f8808d6

Hit counter in backend increases properly now even if cache is turned on. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8887.

avatar brianteeman brianteeman - change - 15 Jan 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Jan 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8887.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 16 Jan 2016

Milestone to bet set to 3.5.0 as this is a bug correction.

avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 00:26:46
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment