[#8816] - Allowing to exclude menu items from displaying in frontend menus (in menu item)
- Closed
- 26 Jan 2016
- Medium
- Build: staging
- # 8816
- Diff
- andrepereiradasilva:menu-items-exclude
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
This is PR takes the contributions from #8814 and adds the ability to exclude menu items from displaying in frontend menus.
For more info see #8814
How to test
- Fresh Joomla install with multilanguage.
- Apply this patch
- Go to a menu item that is displayed in the frontend main menu, separator "Link Type" and set the option "Display in Menu Modules" to "No" to exclude the menu item from displaying in the frontend menu.
- Check in the frontend it those items are not displayed in the main menu.
Observations
Suggestions are welcome.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
I have tested this item 
successfully on 3d547b6
I have successfully tested this PR by using a bunch of different menu types (item alias, menu heading, text separator, external url, articles, tags, etc).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
just curious (cannot test now) how it will work if parent menu is "hidden" but the children is visible? ... on first look it will fail
This PR has received new commits.
CC: @justinherrin
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
I have tested this item successfully on 237811c
Test OK, simple menu item and parent menu item tested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
I have tested this item successfully on 237811c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
| Labels |
Added:
?
|
||
@anibalsanchez @NLRoosj thanks for testing
rdeutz
- | Milestone |
Added: |
||
Currently we suggest people to create separate menu type and add such menu items which they don't want to show. This PR sounds better than that.
@andrepereiradasilva Can you please elaborate over what benefits this is supposed to give us? As you are the author, you have better insights than me.
In my view the benefits are:
1. You don't have to create an "hidden menu" for hidden menu items. You just put then in the menu you want and then hide the items you want with this option.
2. You can now hide only second, third, etc level menu items levels from the menu keeping the information architecture itself organized (breadcrumb, sitemap, sef uri's, etc) as it should.
3. Usability. IMHO it's simpler for a user to understand this behavior.
ex: A user is in a menu item that he don't want to appear in the site menu ... he just select this new option in the menu item itself and hide it. Simple as that. No tricks
4. BC. You can still create an "hidden menu" item as you do before, if you wish so.
Great! Point no. 2 is what cheers me.
Can you also add Hide and Unhide buttons in the list view just like the publish/unpublish behaviour for quick access. Better if we can add a column too in the list view for this.
In fact, I think this option is simpler than separated "hidden menu". A "hidden menu" is a trick that usually leads to have many assorted menu items, with no cohesion.
I have tested this item successfully on 237811c
Does what it says - a useful addition
Made some suggestions to simplify the text a bit and make it better english
I do still wonder if it would not be better as Show/Hide instead of Yes/No - that would seem more appropriate to me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
I think this should be in line with properties like published. Params is
not much appropriate IMHO.
Also see my other comments whether those make sense.
This PR has received new commits.
CC: @anibalsanchez, @brianteeman, @justinherrin, @NLRoosj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8816.
@izharaazmi i tought about your comments,
I think this should be in line with properties like published. Params is not much appropriate IMHO.
I see several problems with that:
1. A menu item can be Published and hidden, or Not Published and hidden so is not a state like Published, Not Published, Trashed.
2. Consistensy: none of the other components have an hidden state.
Can you also add Hide and Unhide buttons in the list view just like the publish/unpublish behaviour for quick access. Better if we can add a column too in the list view for this.
Like the "featured" button in the articles list view?
I guess it can be done with a new field in the table. But is it really worth it? Will it not create some confusion to new users?
IMHO, that is to much emphasis for a option to hide a menu item in the menu modules.
I do still wonder if it would not be better as Show/Hide instead of Yes/No - that would seem more appropriate to me
I put "Yes/No" to use the same as "Add Menu Title" "Yes/No" in the same tab.
But if you guys think "Show/Hide" (with a colour dropdown?) is better i can change it.
Well, sounds great to me.
I still think three things will be very useful for the common/average users (priority top to bottom):
- Bulk action (using checkboxes) to hide/unhide items.
- A way to quickly say which menu item is hidden or not, without needing to open/edit and lookup each one.
- Filter by visibility.
Tell me if you want me to do the PR for (any of) these.
Regarding #8814. I see this one has also great usability. Assume some case when we want to render same menu and show different set of menu items in different menu module positions!
With that we could override/inherit the selections at will.
Can we have a second opinion @brianteeman?
Great work @andrepereiradasilva.
Let's stick to the subject of this PR and not discuss other ones
I still think three things will be very useful for the common/average users (priority top to bottom):
Bulk action (using checkboxes) to hide/unhide items.
A way to quickly say which menu item is hidden or not, without needing to open/edit and lookup each one.
Filter by visibility.
@izharaazmi I will not do more PR regarding this matter (i have other PR to do).
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-26 10:44:11 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Merged for 3.5.0 - thanks @andrepereiradasilva :)
| Labels |
Removed:
?
|
||
@justinherrin done.
Can you test if everything ok now?