User tests: Successful: Unsuccessful:
This PR adds language flags to listing tables in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) in administrator panel.
For com_weblinks check joomla-extensions/weblinks#176
Suggestions are welcome.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Title |
|
Title |
|
@infograf768 i made some changes.
Transformed the image in a button like the "star" buttons. Example:
Also had a bootstrap tooltip with the native language like the "star" buttons.
Tested and it works, but still want to do some review to the jgrid code.
Another way, that will be more near to waht you proposed is to put also put the language native name inside the button.
What do you think?
The button is a nice idea.
Adding the flag in the tooltip looks a bit overkill.
Putting the language name inside the button would make the button quite enormous.
@infograf768 i will make a new PR for the default language buttons in templates and menus. This one will stay just for the language flags in the language columns.
I improved a bit the code and added them to hathor too.
For com_weblinks i created a PR joomla-extensions/weblinks#176 and a change to hathor weblinks override (b40b35e) here.
@infograf768 the language buttons are in this PR: #8826
I have tested this item successfully on b40b35e
Once the conflict is solved (tag), perfect improvement. Thanks.
Thanks.
Once the conflict is solved (tag)
Didn't understand ...
@andrepereiradasilva you have to resync this as there is a msg: This branch has conflicts that must be resolved
at the end of this page...
This PR has received new commits.
CC: @infograf768
This PR has received new commits.
CC: @infograf768
No conflicts now.
I have tested this item successfully on 84e643a
Could you modify the size of the language column for the menu items list?
from 5% to 15%
<th width="15%" class="nowrap hidden-phone">
<?php echo JHtml::_('searchtools.sort', 'JGRID_HEADING_LANGUAGE', 'language', $this->state->get('list.direction'), $this->state->get('list.ordering')); ?>
</th>
This will let longer Content Languages names display on one line when screen is larger than 800 px.
Good spot @infograf768
Looking at the other views it looks like they are all at 10%
Looking at the other views it looks like they are all at 10%
yes, but in the menu items list it looks like using 15% is much better because Home is set to 5%
This PR has received new commits.
CC: @brianteeman, @infograf768
@infograf768, @brianteeman 15% now.
I have tested this item successfully on 850a8e5
I have tested this item successfully on 850a8e5
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-26 23:36:24 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
This works fine.
I propose to add a similar UX for template styles.
I also added the tooltip:
Diff available here:
https://www.dropbox.com/s/b9azgs1ck1jb3i7/template_styles.diff?dl=0