? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
30 Dec 2015

Description

This PR adds language flags to listing tables in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) in administrator panel.

Example:
langs

How to test

  1. Fresh Joomla install with multilanguage (several languages).
  2. Apply this patch
  3. Check if flags are displayed in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) listings.
  4. Do the same for hathor template.

For com_weblinks check joomla-extensions/weblinks#176

Observations

Suggestions are welcome.

avatar andrepereiradasilva andrepereiradasilva - open - 30 Dec 2015
avatar andrepereiradasilva andrepereiradasilva - change - 30 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2015
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 30 Dec 2015
Title
Adds language flags to listing tables (menu items, categories, articles, featured articles and modules)
Adds language flags to listing tables
avatar andrepereiradasilva andrepereiradasilva - change - 30 Dec 2015
The description was changed
Title
Adds language flags to listing tables (menu items, categories, articles, featured articles and modules)
Adds language flags to listing tables
avatar andrepereiradasilva andrepereiradasilva - change - 30 Dec 2015
The description was changed
avatar infograf768
infograf768 - comment - 31 Dec 2015

This works fine.
I propose to add a similar UX for template styles.
I also added the tooltip:

screen shot 2015-12-31 at 08 57 29

Diff available here:
https://www.dropbox.com/s/b9azgs1ck1jb3i7/template_styles.diff?dl=0

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Dec 2015

@infograf768 i made some changes.

  • Transformed the image in a button like the "star" buttons. Example:
    image

  • Also had a bootstrap tooltip with the native language like the "star" buttons.

  • Also now uses the same 'jgrid.isdefault' JHtml method like the "star" buttons.

Tested and it works, but still want to do some review to the jgrid code.

Another way, that will be more near to waht you proposed is to put also put the language native name inside the button.

What do you think?

avatar infograf768
infograf768 - comment - 1 Jan 2016

The button is a nice idea.
Adding the flag in the tooltip looks a bit overkill. :smiley:
Putting the language name inside the button would make the button quite enormous.

avatar andrepereiradasilva andrepereiradasilva - reference | 4596d0c - 2 Jan 16
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Jan 2016

@infograf768 i will make a new PR for the default language buttons in templates and menus. This one will stay just for the language flags in the language columns.

I improved a bit the code and added them to hathor too.

For com_weblinks i created a PR joomla-extensions/weblinks#176 and a change to hathor weblinks override (b40b35e) here.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Jan 2016

@infograf768 the language buttons are in this PR: #8826

avatar infograf768 infograf768 - test_item - 11 Jan 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 11 Jan 2016

I have tested this item :white_check_mark: successfully on b40b35e

Once the conflict is solved (tag), perfect improvement. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Jan 2016

Thanks.

Once the conflict is solved (tag)
Didn't understand ...

avatar dgt41
dgt41 - comment - 11 Jan 2016

@andrepereiradasilva you have to resync this as there is a msg: This branch has conflicts that must be resolved at the end of this page...

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Jan 2016

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Jan 2016

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jan 2016

No conflicts now.

avatar brianteeman brianteeman - test_item - 21 Jan 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Jan 2016

I have tested this item :white_check_mark: successfully on 84e643a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar infograf768
infograf768 - comment - 22 Jan 2016

@andrepereiradasilva

Could you modify the size of the language column for the menu items list?
from 5% to 15%

<th width="15%" class="nowrap hidden-phone">
                            <?php echo JHtml::_('searchtools.sort', 'JGRID_HEADING_LANGUAGE', 'language', $this->state->get('list.direction'), $this->state->get('list.ordering')); ?>
                        </th>

This will let longer Content Languages names display on one line when screen is larger than 800 px.
screen shot 2016-01-22 at 10 32 19

avatar brianteeman
brianteeman - comment - 22 Jan 2016

Good spot @infograf768
Looking at the other views it looks like they are all at 10%

avatar infograf768
infograf768 - comment - 22 Jan 2016

Looking at the other views it looks like they are all at 10%

yes, but in the menu items list it looks like using 15% is much better because Home is set to 5%

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Jan 2016

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Jan 2016
avatar infograf768 infograf768 - test_item - 25 Jan 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Jan 2016

I have tested this item :white_check_mark: successfully on 850a8e5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar brianteeman brianteeman - test_item - 25 Jan 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Jan 2016

I have tested this item :white_check_mark: successfully on 850a8e5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar infograf768 infograf768 - change - 26 Jan 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 26 Jan 2016

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 26 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-26 23:36:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 Jan 2016
avatar wilsonge wilsonge - close - 26 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 27 Jan 2016

Add a Comment

Login with GitHub to post a comment