Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8783] - When saving a tag with empty metadesc or metakey white space is saved

? Success

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
24 Dec 2015

Fixes one part of #8781

Create one or more new tags.
Just enter a title and save.
Afterwards check field Meta Description. A white space instead of empty.

Apply tag(s) to one or more articles.

Create a menu item of type "tagged items". Select created tag(s).
Enter a Meta Description "Blah Blah".
Enter Meta Keywords "juckie puckie".
Open menu item in frontend and see source code of page.

  <meta name="keywords" content=" " />
  <meta name="description" content=" " />

Apply patch and try again.
(Or just open tags one after the other and delete white spaces from fields Meta Description and Meta Keywords and save tag).

  <meta name="keywords" content="juckie puckie" />
  <meta name="description" content="Blah Blah" />
avatar bertmert bertmert - open - 24 Dec 2015
avatar bertmert bertmert - change - 24 Dec 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 27 Dec 2015
Category ⇒ Tags
avatar hakanara hakanara - test_item - 4 Jan 2016 - Tested successfully
avatar hakanara
hakanara - comment - 4 Jan 2016

I have tested this item :white_check_mark: successfully on e7a3568

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8783.

avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Jan 2016

I think the spaces were added in bertmert@2f76e54

avatar bertmert
bertmert - comment - 4 Jan 2016

I think the spaces were added in bertmert@2f76e54

I think you mean
https://github.com/joomla/joomla-cms/pull/6314/files

I don't understand your comment. So, you think this PR here is wrong? Why, please?

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jan 2016

Yes that. My mistake.

Just wondering if the spaces were added because of postgresql. Did you test in postgresql?

avatar bertmert
bertmert - comment - 5 Jan 2016

Also in postgresql both fields are of type varchar. Empty strings are allowed.
If there are problems with postgresql (don't know) then this should be fixed there not in PHP relevant for all DB systems. A whitespace metadescription in 99.9% of all cases and/or a wrong one (more or less random tag metadescription) instead of expected menu item metadescription (or global one) is a bug from my point of view.

BTW: I think (not only) metadesc and metakey should be removed completely from tags (#__tags). There are nearly no scenarios where it makes sense. Completely confusing random outputs. Depends on ordering of tags and so on. It's like entering a metadesc for any metakey somehow.
Only in views where a single tag is shown it could make sense sometimes(!).

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jan 2016

Makes sense IMHO.

avatar anibalsanchez anibalsanchez - test_item - 6 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 6 Jan 2016

I have tested this item :white_check_mark: successfully on e7a3568

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8783.

avatar brianteeman brianteeman - change - 6 Jan 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Jan 2016

RTC - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8783.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-01-17 15:49:27
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment