Feeling Lucky
?
[#8702] - Add type hinting to JComponentRouterBase
- Closed
- 25 Aug 2016
- Medium
- Build: staging
- # 8702
- Diff
- malukenho:enhancement/add-type-hinting
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Add type hinting to JComponentRouterBase and simplify assigns
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Hackwar
- comment
- 23 Feb 2016
Basically, I would rather type hint an interface and not a specific class like JMenu or JApplicationCms... In any case, you would have to change the unittests to work with those type hints, too.
| Category | ⇒ | Libraries |
brianteeman
- comment
- 25 Aug 2016
I am closing this at this time. As stated above it needs unittests before it gets merged and I assume that as there has been no update they wont be forthcoming
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 14:06:07 |
| Closed_By | ⇒ | brianteeman |
Hello @malukenho, I did not add type hinting here, because you should be able to hand in almost arbitrary objects, mainly to allow for proper unittesting.