[#8701] - Replace switch with if statement
- Closed
- 29 Jan 2016
- Medium
- Build: staging
- # 8701
- Diff
- malukenho:enhancement/replace-unecessary-switch
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
.
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | New |
| Labels |
Added:
?
?
|
||
| Status | New | ⇒ | Pending |
Why is this necessary?
Generally speaking, Due to the fact that switch does no comparison, it is slightly faster.
If the variable part is a function call (as is in this case) then switch is better since there is only one call to the function.
Maintainability down the road, what if there is more cases than just HTML (XML, JSON, RAW, etc). then using a switch seems to make even more sense.
Approve of the change for this situation. Consider a simple if much easier to read than the current switch.
As soon as other cases are introduced it should go back to a switch statement.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-29 18:09:55 |
| Closed_By | ⇒ | brianteeman |
Closed as no test instructions and/or any description were provided as requested.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8701.
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.