[#8684] - PlgSystemUpdatenotification::getSuperUsers - replace query with API call
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 8684
- Diff
- klas:updatenotification
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
PlgSystemUpdatenotification::getSuperUsers is doing direct database queries to find groups with superuser permissions. We have existing API that should be used for this (to avoid code duplication and maintainance problems).
To test check behaviour of notification plugin before and after the patch, it should stay the same.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | ⇒ | Plugins Updating |
@klas, how can I test this exactly.
Then I can ask PBF visitors to test this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.
@conconnl getSuperUsers fuction behaviour should stay the same, what specifically you can test is that the same set of superusers gets email notification about update than before patch (emails are sent either to superusers with emails matching those from the list or all superusers, if no emails have been set in the plugin)
@klas I have tried to test it but can't seem to trigger the update mails.
I manually changed the version numbers in the files, but the update mechanism in Joomla can't find a update even when I use 3.4.0 as number.
I you know which changes are needed to trigger it, then I would gladly test it again.
I have tested this item
First I tried to trigger the update notification by manually change the version string.
This step worked worked and the backend popup to update. But it didn't send an email to the superuser (pre-patch).
So I vardumpped the codenotification.php return values that are affected by the patch and compared them with the return values of the patched code.
Pre- and postpatch returned the same values.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.
I have tested this item
changed the version in database and cleared cache. dumped the return information from ./plugins/system/updatenotification/updatenotification.php
both looked the same. @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.
| Status | Pending | ⇒ | Ready to Commit |
RTC as we have 2 successful tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.
| Category | Plugins Updating | ⇒ | Plugins Front End Updating |
| Labels |
Added:
?
|
||
Thank you all for testing
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:00:01 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
NOTE: The travis errors are unrelated to this PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.