? Success

User tests: Successful: Unsuccessful:

avatar klas
klas
14 Dec 2015

PlgSystemUpdatenotification::getSuperUsers is doing direct database queries to find groups with superuser permissions. We have existing API that should be used for this (to avoid code duplication and maintainance problems).

To test check behaviour of notification plugin before and after the patch, it should stay the same.

avatar klas klas - open - 14 Dec 2015
avatar klas klas - change - 14 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2015
Labels Added: ?
avatar klas klas - change - 14 Dec 2015
Title
PlgSystemUpdatenotification::getSuperUsers - replace query wirh API call
PlgSystemUpdatenotification::getSuperUsers - replace query with API call
avatar brianteeman brianteeman - change - 14 Dec 2015
Category Plugins Updating
avatar brianteeman
brianteeman - comment - 14 Dec 2015

NOTE: The travis errors are unrelated to this PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.

avatar Bakual
Bakual - comment - 14 Dec 2015

@klas Can you update your PR with current staging. The codestyle issues which went in with the 3.4.6 release are now fixed.

avatar klas
klas - comment - 15 Dec 2015

@Bakual Done

avatar conconnl
conconnl - comment - 28 Jun 2016

@klas, how can I test this exactly.
Then I can ask PBF visitors to test this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.

avatar klas
klas - comment - 28 Jun 2016

@conconnl getSuperUsers fuction behaviour should stay the same, what specifically you can test is that the same set of superusers gets email notification about update than before patch (emails are sent either to superusers with emails matching those from the list or all superusers, if no emails have been set in the plugin)

avatar conconnl
conconnl - comment - 28 Jun 2016

@klas I have tried to test it but can't seem to trigger the update mails.
I manually changed the version numbers in the files, but the update mechanism in Joomla can't find a update even when I use 3.4.0 as number.

I you know which changes are needed to trigger it, then I would gladly test it again.

avatar faynt0 faynt0 - test_item - 1 Aug 2016 - Tested successfully
avatar faynt0
faynt0 - comment - 1 Aug 2016

I have tested this item successfully on 91d4e47

First I tried to trigger the update notification by manually change the version string.
This step worked worked and the backend popup to update. But it didn't send an email to the superuser (pre-patch).
So I vardumpped the codenotification.php return values that are affected by the patch and compared them with the return values of the patched code.
Pre- and postpatch returned the same values.

@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.

avatar wmchris wmchris - test_item - 2 Aug 2016 - Tested successfully
avatar wmchris
wmchris - comment - 2 Aug 2016

I have tested this item successfully on 91d4e47

changed the version in database and cleared cache. dumped the return information from ./plugins/system/updatenotification/updatenotification.php

both looked the same. @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.

avatar roland-d roland-d - change - 2 Aug 2016
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 2 Aug 2016

RTC as we have 2 successful tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8684.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2016
Category Plugins Updating Plugins Front End Updating
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2016
Labels Added: ?
avatar klas
klas - comment - 3 Aug 2016

Thank you all for testing

avatar rdeutz rdeutz - change - 13 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 17:00:01
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Aug 2016
avatar rdeutz rdeutz - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment