[#8587] - Fix JUri::root() assignment from backend app constuctor
- Fixed in Code Base
- 25 Jun 2016
- Medium
- Build: staging
- # 8587
- Diff
- izharaazmi:patch-5
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This may not seem any important but I'd say it still is breaking. Try running Joomla in a subdirectory administrator under your web root, and open backend. It would break.
example.com/administrator/administrator/index.php
dirname will work on all platforms as JUri::base(true) always uses / as the path separator. Also there is no trailing slash in the return value of JUri::base(true)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.
I have tested this item
Patch tested successfully on Joomla! 3.6.0-beta2
I've installed Joomla in a folder called /administrator/ and going to the /administrator/administrator/ results in a blank page.
I've manually added the code of this patch to the file, and it solves the problem.
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.
I have tested this item
Patch tested successfully on Joomla! 3.6.0-beta2
I've installed Joomla in a folder called /administrator/ and going to the /administrator/administrator/ results in a blank page.
I've manually added the code of this patch to the file, and it solves the problem.
// JUri::root(null, str_ireplace('/' . $this->getName(), '', JUri::base(true)));
JUri::root(null, rtrim(dirname(JUri::base(true)), '/'));
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.
I have tested this item
Also works for placing joomla in sub-folder like
/administrator*/
e.g.
/administrator_2/
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-25 20:46:25 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item
successfully on fb59736
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587.