Feeling Lucky
?
[#8586] - Fix undefined variable $skin and minimize code in TinyMCE
- Closed
- 11 Mar 2016
- Medium
- Build: staging
- # 8586
- Diff
- izharaazmi:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fixes two things:
- First, undefined variable $skins in the switch cases at the end of this method when
isSiteandisAdminboth fails (please don't say this can't happen). - Second, minimize the code by providing fallback value once.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
izharaazmi
- comment
- 3 Dec 2015
@dgt41 Okay. But I see that PR assumes all clients which are not admin must be site.
I always try to discourage this assumption in my team and hope I can some day convince the community too. Currently this wrong assumption is everywhere in the CMS. I'll try to remove them all.
Not all non-males are females and vice-versa. These are not boolean.
Otherwise that PR (#8544) looks fine.
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-11 22:34:36 |
| Closed_By | ⇒ | brianteeman |
brianteeman
- comment
- 11 Mar 2016
Closed as requested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8586.
@izharaazmi there is also #8544