Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8583] - Reattempt 8024

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
2 Dec 2015

This fixes the bad merge of #8024 by reverting 88fb40b and reapplying the diff from the pull request.

avatar mbabker mbabker - open - 2 Dec 2015
avatar mbabker mbabker - change - 2 Dec 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Dec 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 3 Dec 2015

What shall we check for when testing?

avatar Bakual
Bakual - comment - 3 Dec 2015

@wilsonge @roland-d As you were involved in the original merge, please review.

avatar mbabker
mbabker - comment - 3 Dec 2015

What shall we check for when testing?

This should be mostly review and validation that things are in the same state they were before the reverted commit. The diff shows a majority of the changes are code style related or replacing calls to the deprecated $app->getCfg()

avatar roland-d
roland-d - comment - 4 Dec 2015

@mbabker Thanks for the PR, I have reviewed the changes and they look good to me. @wilsonge You want to go over it as well? After that we can merge this if all looks good to you.

avatar wilsonge wilsonge - change - 4 Dec 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-12-04 21:00:36
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 4 Dec 2015
avatar wilsonge wilsonge - reference | d978f66 - 4 Dec 15
avatar wilsonge wilsonge - merge - 4 Dec 2015
avatar wilsonge wilsonge - close - 4 Dec 2015
avatar wilsonge
wilsonge - comment - 4 Dec 2015

Merged on review

avatar mbabker mbabker - head_ref_deleted - 4 Dec 2015
avatar zero-24 zero-24 - change - 4 Dec 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment