[#8582] - Email this link to a friend doesn't work with caching enabled
- Closed
- 26 Apr 2019
- Medium
- Build: master
- # 8582
Steps to reproduce the issue
Enable cache com_content
Load an article from the front-end component com_content
Open a new private browsing (To generate a new session)
Use "Email this link to a friend" from the icons
Expected result
The link is sent to a friend.
Actual result
COM_MAILTO_EMAIL_NOT_SENT
/components/com_mailto/controller.php
$link = MailtoHelper::validateHash($this->input->get('link', '', 'post'));
if (!$link || !JUri::isInternal($link))
{
// Non-local url...
JError::raiseNotice(500, JText::_('COM_MAILTO_EMAIL_NOT_SENT'));
return $this->mailto();
}
System information (as much as possible)
/components/com_content/helpers/icon.php
JHtmlIcon::email
line 90: $url = 'index.php?option=com_mailto&tmpl=component&template=' . $template . '&link=' . MailToHelper::addLink($link);
MailToHelper::addLink -> adds a URL to the mailto system and returns the hash.
But only in the first session!!
Later the others users will get the hash from the cached file.
/components/com_mailto/controller.php
And when the controller of com_mailto use MailtoHelper::validateHash
Line 61: $mailto_links = $session->get('com_mailto.links', array());
This returns an empty array to de new users.
Additional comments
Spam deleted!
| Status | New | ⇒ | Confirmed |
I can confirm that if you enable cache
Open an article and then open the same article in a private window
Using "Email this link to a friend" it was sent successfuly in the first window but in the private window I got a "Email could not be sent."
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8582.
After mostly every Joomla update I'll get the errors on the option email to a friend. I found my solution on Voodish. You'll search for the file /components/com_mailto/controller.php
Locate the following line of code (approximately line 57):
if($timeout == 0 || time() - $timeout < 20) {
Change the line to the following:
if($timeout == 0 || time() - $timeout > 20) {
Save, Upload and test.
You can also increase the time from 20 to say 50.
Tnx to voodish
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8582.
Issue still valid.
I can confirm in Joomla! 3.7.0-staging
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8582.
I can confirm the problem on Joomla! 3.7.1-dev (nightly Build)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8582.
| Status | Confirmed | ⇒ | Needs Review |
Status is set on "Needs Review".
| Status | Needs Review | ⇒ | Pending |
Set to pending, it's just a bug
| Status | Pending | ⇒ | Discussion |
| Status | Discussion | ⇒ | Known Issue |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-13 14:50:28 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Status | Known Issue | ⇒ | Closed |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/8582
| Status | Closed | ⇒ | Discussion |
| Closed_Date | 2017-11-13 14:50:28 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Status | Discussion | ⇒ | New |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/8582
| Status | New | ⇒ | Discussion |
| Labels |
Added:
J3 Issue
|
||
i'm unable to reproduce this issue with current staging
p.s
i'll close this issue in a week if no other feedback
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-26 15:31:52 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | alikon |
| Labels | |||
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/8582
closing as it seems no more reproducible
it always can be reopened if needed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8582.
@dodiaraculus17
Please stop spamming our repo!