? ? Success
Referenced as Pull Request for: # 9906

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
1 Dec 2015

com_contact has the possibility to add photos to each contact. The photo can be showed on the view of a single contact, but not in the list of contacts inside a category.
I added two new fields under the List Layouts options to be able to display the contact photo in the list of contacts:
screenshot 141

That is the view (I added Bootstrap 2 and 3 classes to make it compatible with the two versions of the framework):
screenshot 142

I also added a definition into the CSS file of Protostar to correct the display of the rows.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar drmenzelit drmenzelit - open - 1 Dec 2015
avatar drmenzelit drmenzelit - change - 1 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Dec 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 3 Dec 2015

Have you tested the CSS with a RTL language?

avatar drmenzelit
drmenzelit - comment - 3 Dec 2015

What do you mean infograf768? I used the standard Protostar to test. I think if someone wants to change the order of the columns to show from right to left, then he/she has to create an override of the view.

avatar infograf768
infograf768 - comment - 3 Dec 2015

was just wondering about

.contact-category .row {
    margin-left: 0;
}

but, after testing, it looks like it is OK both in RTL and LTR

avatar drmenzelit
drmenzelit - comment - 3 Dec 2015

I added this line to the CSS because in Protostar "row" is defined with margin-left: -20px

avatar waader waader - test_item - 9 Dec 2015 - Tested successfully
avatar waader
waader - comment - 9 Dec 2015

I have tested this item :white_check_mark: successfully on 7274628

Works fine, thanks! Shouldn´t this also be added to Beez?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar drmenzelit
drmenzelit - comment - 9 Dec 2015

It can also be added to the override of Beez...

avatar kleinhelmi kleinhelmi - test_item - 14 Dec 2015 - Tested successfully
avatar kleinhelmi
kleinhelmi - comment - 14 Dec 2015

I have tested this item :white_check_mark: successfully on 7274628

tested with Joomla 3.5.0-beta @ Apache/2.4.10 (Win32) OpenSSL/1.0.1i PHP/5.5.15


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot
joomla-cms-bot - comment - 28 Dec 2015

This PR has received new commits.

CC: @kleinhelmi, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar brianteeman brianteeman - change - 28 Mar 2016
Category Components
avatar brianteeman brianteeman - change - 28 Mar 2016
Labels
avatar mikeveeckmans mikeveeckmans - test_item - 30 Mar 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on 2a8f4f4

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar brianteeman brianteeman - change - 30 Mar 2016
Category Components Components Language & Strings
avatar brianteeman brianteeman - change - 30 Mar 2016
Labels
avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 30 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 6 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar wilsonge
wilsonge - comment - 12 Apr 2016

OK I'm going to make an executive decision here. Can we remove the param for setting column widths please? It's unnecessary - we have far too many params as it is - template overrides are easy to create for that sort of thing

avatar wilsonge wilsonge - change - 12 Apr 2016
Labels Removed: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 13 Apr 2016

@wilsonge I removed the parameter for column width

avatar wilsonge
wilsonge - comment - 13 Apr 2016

Thanks! Now can you add back the installation directory please :)

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar mikeveeckmans
mikeveeckmans - comment - 13 Apr 2016

ready for test ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar rdeutz rdeutz - change - 13 Apr 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar brianteeman brianteeman - change - 14 Apr 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-04-14 09:25:05
Closed_By brianteeman
Labels
avatar brianteeman brianteeman - change - 14 Apr 2016
Closed_Date 2016-04-14 09:25:05 2016-04-14 09:25:06
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Status Closed New
Closed_Date 2016-04-14 09:25:06
Closed_By brianteeman
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Status New Pending
avatar brianteeman
brianteeman - comment - 14 Apr 2016

Closed please retest #9906


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 14 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-14 09:25:53
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment