User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Components |
I have tested this item successfully on 96822b7
TEST OK
I have tested this item unsuccessfully on 96822b7
I added a cuatom template override and it doesn´t appear in the list.
Btw: We tested also when adding an override for an article, and that worked. But that seems not logical to me, because i expect to be able to choose a category list override there?
Maybe we need then two fields there 1) List view layout and 2) Article view layout
I have tested this item successfully on 96822b7
Alternative Layout is working for Articles. It's a bit confusing. It should be called Alternative Layout for Articles.
Alternative Layout is working for Article. It's a bit confusing. It should be called Alternative Layout for Articles.
This PR has received new commits.
CC: @designbengel, @mikeveeckmans, @webnet-assmann
Yes i agree that if we change the label to Alternative Layout for Articles would be more clear.
Need to add the language then. I'll add the correct language.
This PR has received new commits.
CC: @designbengel, @mikeveeckmans, @webnet-assmann
This PR has received new commits.
CC: @designbengel, @mikeveeckmans, @webnet-assmann
Labels |
Added:
?
|
Category | Components | ⇒ | Components Language & Strings |
Labels |
@shamsbd71 are all the comments integrated in the patch?
If so, I and hopefully others can test this PR.
I have tested this item
field alternative layout didn't appear @icampus
@schmidtpaddy there are two files, please try both. you have applied only language file changes.
https://github.com/joomla/joomla-cms/pull/8579/files
thanks
I have tested this item
tested:
•install plugin successfully
•everything worked well @icampus
@schmidtpaddy Can you test this once more please? Thanks.
Alternative Layout for Article is Display and is a good feature but
I have testet #8579 the "Alternative Layout for Article" and see this problem (with and without SEO):
For example go to article-category-list-menuitem A -> Details -> Template Style and change to an other Template with Template-Override
( with a not default name of the override(unique name) ; for example: /html/com_content/article/my-66-override.php )
then go to List Layouts -> Alternative Layout for Article and see the not correct list in.
Then click the "Save"-Button and go Back to List Layouts -> Alternative Layout for Article and see the correct list now.
Now select this override "my-66-override" and save it.
Now the PR works as expected but if you now go to
article-category-list-menuitem A -> Details -> Template Style and change to an other Template and save it.
Then works the override furthermore.
If you now go to the article-category-list-menuitem to List Layouts -> Alternative Layout for Article and change this to "From Component -> default" and save it then is come the expected result(view without the override from the other Template).
Similar problem as in my post in #8578
I hope this is helpful.
You make two article-category-list-menuitems A B
both for the same article-category
This is wrong! you should not create the same menu twice and it's not practical either.
If you check Joomla routing, you are creating confusion for the routing not for the menu item.
This setting works based on menu item id. so when you have duplicate menu itemid for the same category, you are confusing yourself :(
thanks
But the Problem in my first post in this PR is a problem that comes with this PR.
To solve this it is additional or changed code required.
I have tested this item
I tested this - first to confirm that the Alternative Layout selector was not available. Then I used the Patch Tester to install the patch. Then created a Category List menu item. Then check to see if the Alternative Layout selector was visible - it was. Then I created an article alternative layout override. Then I visited the Category List menu item, and the Alternative Layout I created was also visible and selectable.
I have tested this item
All works like @microtribe wrote above, but "Show Votes in List" and "Show Ratings in List" isn't shown anymore after Patch.
Status | Pending | ⇒ | Needs Review |
Category | Components Language & Strings | ⇒ | Administration Language & Strings Front End com_content Components |
This PR needs to be synchronized with the current development branches and the issues addressed for it to be reviewed.
Status | Needs Review | ⇒ | Information Required |
If this PR get no Response, it will be closed at 22th June 2017.
How to sync it? should i create a new PR on the latest staging and reference it?
@coolcat-creations yes that will be the easiest in this case
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-18 19:54:28 |
Closed_By | ⇒ | brianteeman |
Test OK.
I hadn't figured out it was missing. But actually, it is.
TKS.