Joomla! Issue Tracker | Joomla! CMS #8572 - #8470 fixed help site link per user issue

Closed
16 Dec 2015
Medium
Build: staging
# 8572
Diff
RonakParmar:8470_help_site_link_per_user

Success

Success Human Test Results: 2 Successful 0 Failed. Details

Referenced as Pull Request for: ~~# 8470~~

User tests: Successful: Unsuccessful:

RonakParmar
30 Nov 2015

Fixed help site link per user issue.
https://issues.joomla.org/tracker/joomla-cms/8470

Votes

# of Users Experiencing Issue

1/1

Average Importance Score

5.00

e2d9e9e 30 Nov 2015

#8470 fixed help site link per user issue

RonakParmar - open - 30 Nov 2015

RonakParmar - change - 30 Nov 2015

Status

New

⇒

Pending

joomla-cms-bot - change - 30 Nov 2015

Labels

Added: ?

gunjanpatel - test_item - 30 Nov 2015 - Tested successfully

gunjanpatel - comment - 30 Nov 2015

I have tested this item successfully on e2d9e9e

It works. Thanks @RonakParmar

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

dwarkeshsoni - test_item - 30 Nov 2015 - Tested successfully

dwarkeshsoni - comment - 30 Nov 2015

I have tested this item successfully on e2d9e9e

It works. Thanks @RonakParmar

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - change - 30 Nov 2015

Status

Pending

⇒

Ready to Commit

infograf768 - comment - 30 Nov 2015

RTC. Thanks for testing

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

joomla-cms-bot - change - 30 Nov 2015

Labels

Added: ?

watchfulli-dev - test_item - 1 Dec 2015 - Tested unsuccessfully

watchfulli-dev - comment - 1 Dec 2015

I have tested this item unsuccessfully on e2d9e9e

@test applied the patch but the test fails, when I click refresh button the "Use default" value is gone.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - change - 1 Dec 2015

Status

Ready to Commit

⇒

Pending

infograf768 - comment - 1 Dec 2015

I am taking off RTC here because after PR, the value "Use Default" is also displayed in Global Configuration.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

joomla-cms-bot - change - 1 Dec 2015

Labels

Removed: ?

dwarkeshsoni - test_item - 1 Dec 2015 - Tested successfully

dwarkeshsoni - comment - 1 Dec 2015

I have tested this item successfully on e2d9e9e

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - comment - 1 Dec 2015

Folks, please read above #8572 (comment)
The tests can't be successful

infograf768 - alter_testresult - 1 Dec 2015 - dwarkeshoni: Tested unsuccessfully

infograf768 - alter_testresult - 1 Dec 2015 - dwarkeshsoni: Tested unsuccessfully

infograf768 - alter_testresult - 1 Dec 2015 - gunjanpatel: Tested unsuccessfully

brianteeman - test_item - 1 Dec 2015 - Tested successfully

brianteeman - comment - 1 Dec 2015

I have tested this item successfully on e2d9e9e

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - comment - 1 Dec 2015

test can't be successful because default should not be proposed in global config...

infograf768 - comment - 1 Dec 2015

Also, as the refresh is done from a frontend file, it picks —on a multilingual site— the lang cookie from the last visit of the user in front-end.
Here, I visited Tamil language in front-end (en-GB being used in back-end)

and I get in back-end:

2 good reasons therefore to insist on saying that the PR is no good at this time.

phproberto - comment - 2 Dec 2015

I think what we need is that the field has an option to show/hide the default option (enabled by default).

Something like:

<field
    name="helpurl"
    type="helpsite"
    label="COM_CONFIG_FIELD_HELP_SERVER_LABEL"
    description="COM_CONFIG_FIELD_HELP_SERVER_DESC" 
    showDefault="false"
/>

72eeea5 2 Dec 2015

[imp] allow to set an option to hide the Use default on helpsite field

phproberto - comment - 2 Dec 2015

Please @RonakParmar check:
RonakParmar#1

infograf768 - comment - 2 Dec 2015

Language issue still present after using @phproberto patch

048736b 2 Dec 2015

[imp] use base json profile controller

phproberto - comment - 2 Dec 2015

I have modified the PR to create a base profile json controller that will be extended in frontend + backend controllers so each application returns its own data in its own language. That should solve the language issue.

infograf768 - alter_testresult - 2 Dec 2015 - brianteeman: Not tested

infograf768 - comment - 3 Dec 2015

@RonakParmar

Please merge @phproberto RonakParmar#1 as it solves now both issues (no more "Use default" in Global Configuration, and correct language used in back-end when editing user profile when clicking refresh on multilanguage sites.

9b1b7a4 3 Dec 2015

Merge pull request #1 from phproberto/ronak-8572

joomla-cms-bot - comment - 3 Dec 2015

This PR has received new commits.

CC: @brianteeman, @dwarkeshoni, @dwarkeshsoni, @gunjanpatel, @watchfulli-dev

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

RonakParmar - comment - 3 Dec 2015

@phproberto Thanks for help to fix this "Use Default" in Global Configuration issue.
I have merged your changes.

infograf768 - test_item - 3 Dec 2015 - Tested successfully

infograf768 - comment - 3 Dec 2015

I have tested this item successfully on 9b1b7a4

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - comment - 3 Dec 2015

One more tester please.

dwarkeshsoni - test_item - 3 Dec 2015 - Tested successfully

dwarkeshsoni - comment - 3 Dec 2015

I have tested this item successfully on 9b1b7a4

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

dwarkeshsoni - comment - 3 Dec 2015

Special thanks to @phproberto for fix this issue.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

infograf768 - change - 3 Dec 2015

Status

Pending

⇒

Ready to Commit

infograf768 - comment - 3 Dec 2015

RTC, Maintainers please add to 3.5.0 beta 2

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8572.}

joomla-cms-bot - change - 3 Dec 2015

Labels

Added: ?

pjwiseman - alter_testresult - 8 Dec 2015 - dwarkeshsoni: Tested successfully

pjwiseman - alter_testresult - 8 Dec 2015 - infograf768: Tested successfully

pjwiseman - test_item - 9 Dec 2015 - Not tested

pjwiseman - test_item - 9 Dec 2015 - Tested successfully

pjwiseman - alter_testresult - 9 Dec 2015 - pjwiseman: Not tested

pjwiseman - test_item - 9 Dec 2015 - Tested successfully

pjwiseman - test_item - 9 Dec 2015 - Not tested

roland-d - change - 10 Dec 2015

Milestone

Added:

Kubik-Rubik - comment - 16 Dec 2015

Thank you @RonakParmar / @phproberto and testers. Merged!

Kubik-Rubik - change - 16 Dec 2015

Status	Ready to Commit	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2015-12-16 10:16:54
Closed_By		⇒	Kubik-Rubik

Kubik-Rubik - close - 16 Dec 2015

joomla-cms-bot - close - 16 Dec 2015

joomla-cms-bot - change - 16 Dec 2015

Labels

Removed: ?

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#8572] - #8470 fixed help site link per user issue

Votes

Add a Comment