XTD Buttons (the ones under the editor) are tightly coupled to mootools modal. We can do it in a better way: using bootstrap modals.
B/C
The functionality will not change with this PR. There are overrides both for jModalClose and SqueezeBox.Close functions to close the modal. There is though a possibility that buttons that rely on Mootools functions to stop working (mootools won’t be available). Also any plugins doing javascript calculations for the modal dimensions will render on a predefined modal size (hey we are suppose to do that with css, we are in the responsive era…)
Performance
Again: dropping Mootools is performance gain!
Testing
Set as your default editor either none or code mirror
Edit an article in Isis and in Protostar
Ensure that all buttons work as expected
Please try this also with 3pd buttons
@dgt41 I haven't tested this PR yet. I'll add that to my todo list since I believe in this PR (Mootools is evil ????). I'll try to get to testing it tonight or by this weekend.
photodude
- test_item
- 20 Jan 2016
- Tested successfully
Admin side works in ISIS with or without debug turned on
Site side protostar fails with debug with loging turned on (clicking the article button)
Notice: Trying to get property of non-object in \plugins\system\debug\debug.php on line 1794
Notice: Trying to get property of non-object in \plugins\system\debug\debug.php on line 1795
Without Debug turned on editing buttons in the front end work as expected.
Also note that the vertical height of the modals is smaller (shorter) than before this patch (we really need to fix the modals sizing at some point).
Calling this successful since editing in the front end results in a debug failure with or without this patch, assuming the error is an unrelated issue; therefore successful test.
@dgt41 The only way that @andrepereiradasilva debug changes would have effected this would have been IF the patch tester failed to remove that patch. I'll consider that an outside possibility.
But since @alikon has confirmed the debug issue I reported #8940 as being specific to having enabled log SQL executed query. Let us start there before trying to dig into if the patch tester possibly failed to remove a patch.
anibalsanchez
- test_item
- 27 Jan 2016
- Tested successfully
As there are possible B/C issues I am postponing this for the next major release. In the meantime, @dgt41 can you please fix the merge conflicts? Thank you.
joomla-cms-bot
- 
wilsonge
- 
zero-24
- 
successfully on 0580918
roland-d
- 
brianteeman
-