Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8479] - Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique`

? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
18 Nov 2015

Minimize JArrayHelper methods toInteger, pivot, arrayUnique by using Joomla\Utilities\ArrayHelper internally.
Leaving (reverting from #7782) other four methods as it was originally for b/c reasons as mentioned in #8455.

Thanks @rdeutz

avatar izharaazmi izharaazmi - open - 18 Nov 2015
avatar izharaazmi izharaazmi - change - 18 Nov 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2015
Labels Added: ?
avatar izharaazmi
izharaazmi - comment - 19 Nov 2015

@rdeutz I am not sure if this PR makes any sense after the merge of #8455. Please advise. Do I need to PR afresh for toInteger, pivot and arrayUnique?

avatar rdeutz
rdeutz - comment - 19 Nov 2015

@izharaazmi sure it makes sense #8455 is a revert of #7782, we revert the full PR but there where some good changes in it (#7782) and we should merge them.

avatar izharaazmi
izharaazmi - comment - 19 Nov 2015

@rdeutz But In the changes (diff) I see it is not comparing to latest staging branch content, i.e. after the revert I though diff should show up new differences. Am I missing something?

avatar izharaazmi
izharaazmi - comment - 19 Nov 2015

Oh I just updated my knowledge and I understand how it works. I was just thinking the wrong way :)
Thanks @rdeutz!

avatar rdeutz
rdeutz - comment - 19 Nov 2015

@izharaazmi you're welcome!

avatar zero-24 zero-24 - change - 25 Nov 2015
Category ⇒ Libraries
avatar abuechert abuechert - test_item - 1 Aug 2016 - Tested successfully
avatar abuechert
abuechert - comment - 1 Aug 2016

I have tested this item ✅ successfully on 3a8878e

tested @icampus pizza, bugs & fun.
used the functions toInteger(), pivot() and arrayUnique() from JArrayHelper without patch and with patch and compared the outputs. Outputs were identically.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479.

avatar mehmetalipamukci mehmetalipamukci - test_item - 1 Aug 2016 - Tested successfully
avatar mehmetalipamukci
mehmetalipamukci - comment - 1 Aug 2016

I have tested this item ✅ successfully on 3a8878e

tested @icampus:
besides that JArrayHelper is deprecated, the patch does what it says (Compared class before and after applied patch)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479.

avatar brianteeman brianteeman - change - 1 Aug 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 1 Aug 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Aug 2016

@izharaazmi Can you rebase this please?

avatar izharaazmi izharaazmi - change - 15 Aug 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-15 17:01:48
Closed_By ⇒ izharaazmi
avatar izharaazmi izharaazmi - close - 15 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2016
Labels Removed: ?
avatar izharaazmi izharaazmi - change - 15 Aug 2016
Status Closed ⇒ New
Closed_Date 2016-08-15 17:01:48 ⇒
Closed_By izharaazmi ⇒
avatar izharaazmi izharaazmi - change - 15 Aug 2016
Status New ⇒ Pending
avatar izharaazmi izharaazmi - reopen - 15 Aug 2016
avatar izharaazmi
izharaazmi - comment - 15 Aug 2016

@wilsonge Done. Please verify.

avatar brianteeman brianteeman - change - 22 Aug 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 22 Aug 2016

Setting back to RTC as it was just a rebase @wilsonge

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 22 Aug 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-22 20:04:24
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 22 Aug 2016
avatar rdeutz rdeutz - merge - 22 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 22 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment