? ? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
18 Nov 2015

Unit test should test the interface of a class and not the internals. In this case the getInput Method is tested and this is a protected method. Further more the tests are very basic, they check if properties are set. For the tests reflection and mocking is havily used so it is more a test if reflection works as testing the class. On top the test fails often because now is used and compared later, if this happens at the wrong millsecond the time is different and the test fails.

There is nothing to test or to check

avatar rdeutz rdeutz - open - 18 Nov 2015
avatar rdeutz rdeutz - change - 18 Nov 2015
Milestone Added:
avatar rdeutz rdeutz - change - 18 Nov 2015
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2015
Labels Added: ?
avatar Bakual Bakual - change - 18 Nov 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-11-18 14:59:10
Closed_By Bakual
avatar Bakual Bakual - reference | 0b45a52 - 18 Nov 15
avatar Bakual Bakual - merge - 18 Nov 2015
avatar Bakual Bakual - close - 18 Nov 2015
avatar rdeutz rdeutz - head_ref_deleted - 18 Nov 2015
avatar zero-24
zero-24 - comment - 18 Nov 2015

Thanks @rdeutz and @Bakual that will save our lives :+1:

avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment