@rdeutz can you add this "6 hour grace time" to the postinstall message too?

@rdeutz can you add this "6 hour grace time" to the postinstall message too?

Agree.

@infograf768 @zero-24 I also agree to add this to the post-install if we find testers and merge it

Made a new install. Will let you know exactly when the message is sent (if sent).

I have testet the delay now, in fact it gives 6 + 12 hours because we are checking if the delay between last run and now is bigger then 12 hours. That makes it 18 hours after install what is more then enough to disable a plugin. Atm it fails, I think it is because the stats server isn't running but I will check it.

#How to test

• if you have a tool like LittleSnitch you can control network connections and see if there is something going out
• You can set a breakpoint at line 93, if the execution stops the connection will go out.

The stats server has been running since 4/11/15

@wilsonge could also be me being not fast enough to allow the connection in LittleSnitch

disabled the network filter and it works, but my test doesn't count :-)

I have sent a new PR to @rdeutz rdeutz#2

Now on first run the plugin will show a message asking the user to select the mode it will use:

This allows users to:

• Always allow to send data.
• Send data once and get asked next time the stats try to get sent.
• Never send data.

That message will be shown the first time the plugin is loaded and never again except user selects Once option that will ask the user permission each time the plugin wants to send new data.

In the plugin parameters I have added also some options to configure it:

So now the users can adjust:

• Interval for new stats being sent.
• Mode of the plugin
• Enable debug mode to test the plugin.

You change basically makes it opt-in. We wanted it opt-out explicitely.

If you want to make it opt-in, you can as well just deliver it unpublished and show a postinstall message where people can enable it. No need for any special code then.

I have tested this item successfully on 25abae2

When loading my test site this morning, the first thing it did was trying to get https://developer.joomla.org

So, a good test for me.

I don't think it's opt-in or opt-out. It's opt. No decision is taken for the user.

A disabled plugin + postinstall message wouldn't be so easy to setup for users. It would require 2-3 clicks to explicitly enable it. Here you hace both options in 30 pixels and 1 click away. I don't think is the same...

If you think that nobody is going to enable it then is a bad idea to put it there without asking users.

I don't think it's opt-in or opt-out. It's opt. No decision is taken for the user.

I assume if the user doesn't click anything, it will not send anything. Thus it's opt-in. The user has to actively enable it.

I assume if the user doesn't click anything, it will not send anything. Thus it's opt-in. The user has to actively enable it.

Users have to actively enable OR disable it. The only mandatory thing (if user doesn't want to live with a message always shown in backend) is that they decide the initial mode.

Thus it's just opt :P

PR updated!

Users have to actively enable OR disable it.

The question is what happens if they don't do anything? Answer is: It doesn't send any data. Thus it's opt-in.
Granted, they keep having an annoying message on the screen until they disable it. Similar to postinstall messages, but more annoying

This PR has received new commits.

CC: @infograf768

@Bakual we bug them since they make a decision :-)

Thanks for merging @rdeutz. Can you update the PR description?

@phproberto done, thanks for implementing it, I like the solution.

And we finally have an live example of how to use com_ajax in plugins ;)

How can I test on a site where the plugin has already been installed and ran?

@infograf768 deleting the params for the plugin should do the job

rdeutz#3

This PR has received new commits.

CC: @infograf768

@rdeutz
does not work here after deleting params = I do not get the Notice in Control Panel

Found out: the plugin has to be enabled first (as it does for updates or new installs)
Works nicely!

I have tested this item successfully on 6d8f1b7

I missed one typo. rdeutz#4

BTW Thanks for checking this @brianteeman @infograf768 !

I have tested this item successfully on 6d8f1b7

@rdeutz Great thanks

@jtester works

This PR has received new commits.

CC: @infograf768, @Webdongle

I used "these changes" because there is more than one setting being applied.

rdeutz#6

This PR has received new commits.

CC: @infograf768, @Webdongle

Tested in 2 ways, with slightly differing results.

Methods

1. Update from 3.4.5 to 3.5.0-beta, apply patch for PR using PatchTester
2. New 3.5.0-beta install, but applying this PR before opening in browser

Results

1.
open System - Control Panel
No decision box shown.
New post install message indicated.
New message reads

Stats Collection in Joomla

Since version 3.5.0

Since Joomla 3.5 Joomla contains an anonymous statistics tracking plugin that provides your Joomla version, PHP version, database engine and version, and server operating system. This data is collected in order to ensure that as we develop new versions of Joomla we provide the most optimal software taking advantage of the latest database and PHP features but without loosing significant numbers of users. It became especially clear this was required after the requirement of PHP 5.3.10 was implemented after the release of Joomla 3.3 for implementation of BCrypt passwords.

We are making this data publicly available through our API and we will be providing graphs representing the Joomla version, PHP versions and database engines of sites reporting their data in the interest of transparency to the community and to help 3rd party developers.

If you do not wish to provide the Joomla! project with this information you can simply disable the plugin called System - Joomla! Statistics

Open Plugins -> System - Joomla Statistics
All options showing, but mode is set to "Always send"

I guess that nobody would update a live system in this manner anyway, but I have included the results as a point of interest.

2.
Works as expected
First login to Adminstrator looks like this...

2 tests. RTC

Thanks guys :) Merged