[#8336] - removed unnecessary label + description fields in filter xml
- Fixed in Code Base
- 15 Apr 2016
- Medium
- Build: staging
- Easy Test
- # 8336
- Diff
- pe7er:codestyle-filterxml-remove-unnecessary-labels
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR removes the unnecessary fields of the filter xml files that are used by Search Tools
Most /models/filter_somename.xml files contained a label + description field that is not used by the Search Tools filters.
Example: administrator/components/com_content/models/forms/filter_articles.xml
contains:
<field
name="published"
type="status"
label="COM_CONTENT_FILTER_PUBLISHED"
description="COM_CONTENT_FILTER_PUBLISHED_DESC"
onchange="this.form.submit();"
>
<option value="">JOPTION_SELECT_PUBLISHED</option>
</field>
The label="COM_CONTENT_FILTER_PUBLISHED" and the description="COM_CONTENT_FILTER_PUBLISHED_DESC" are not used. This PR removes those.
The label of the Search Tool Filter label "- Select Status -" is created by the JOPTION_SELECT_PUBLISHED option and is not removed by this PR.
Test Instruction
- All Search Tool filter fields + ordering & list limit dropdowns should work correctly, before and after installing the patch.
- All labels should still be correctly displayed.
- No untranslated COM_SOMECOMPONENT_FILTER_FIELD should be displayed
The Search Tools filter options should be tested for the following components:
- Components > Banners (Banners, Clients & Tracks)
- Content > Categories
- Components > Contacts
- Content > Articles
- Content > Featured Articles
- Content > Smart Search (Indexed Content, Content Maps, Search Filters)
- Extensions > Manage (Manage & Update Sites)
- Extensions > Languages
- Menus > some menu
- Extensions > Modules
- Component > Newsfeeds
- Extensions > Plugins
- Components > Redirects
- Components > Tags
- Users > Manage (Users & User Notes)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Administration |
| Easy | No | ⇒ | Yes |
@pe7er Did you checked, not to leave some orphans in language files, as you just changed the xml files?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8336.
We have a "strange" policy not to remove unused language strings
On 14 Nov 2015 4:18 pm, "peterpeter" notifications@github.com wrote:
@pe7er https://github.com/pe7er Did you checked, not to leave some
orphans in language files, as you just changed the xml files?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/8336
https://issues.joomla.org/tracker/joomla-cms/8336.—
Reply to this email directly or view it on GitHub
#8336 (comment).
The reason why we do not delete obsolete language strings is well known: the language packs may be updated on an older Joomla 3.x version which would need the strings.
I have tested this item 
successfully on 8d97566
Tested all filters in testinsructions
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8336.
Just a thought. I wonder about that there are no labels for e.g. screen readers for these dropdowns at all, also before patch.
I'm not an expert concerning accessibility but if there should be hints I think language placeholders shouldn't be removed as long this is not clarified. Is it?
I have tested this item successfully on 8d97566
@test tested successfully on instructed fields.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8336.
| Category | Administration | ⇒ | Administration Fields |
The issue of there being labels for the screen readers is beyond the scope of this PR. Please create a new issue for that -i am sure there are lots of a11y improvements that can be made everywhere.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8336.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
I would leave these labels as is ... they not used in current template, but maybe somewhere in future, or in someone costume template?
just thought 
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-15 05:41:55 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
had to revert the commit, sorry
It'll always say merged because the PR was merged, even if a later commit reverts the merge commit or any commit that's part of the PR.
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 8d97566
Tested all filters in testinsructions.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8336.