? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
8 Nov 2015

This PR fixes the layout for long titles and long text in the search results of com_search for both the Protostar and the Beez3 template

Testing Instructions

Create a new article with a long title and long article text as described in #8312

Before the PR

with Protostar template

On the front-end use Joomla's Search functionality and search for the article with the long title,
to see that the long title & text mess up the layout.

com_search_results-before-title-before

with Beez3 template

In the back-end change the default template to Beez3
On the front-end use Joomla's Search functionality and search for the article with the long title,
to see that the long title & text mess up the layout.

com_search_results-before-title-beez3-before

After the PR

with Protostar template

This PR should fix the layout

com_search_results-before-title-after

with Beez3 template

This PR should fix the layout

com_search_results-before-title-beez3-after

avatar pe7er pe7er - open - 8 Nov 2015
avatar pe7er pe7er - change - 8 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2015
Category Templates (site)
avatar zero-24 zero-24 - change - 9 Nov 2015
Easy No Yes
avatar waader waader - test_item - 15 Nov 2015 - Tested successfully
avatar waader
waader - comment - 15 Nov 2015

I have tested this item :white_check_mark: successfully on acb6002

Thanks pe7er!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

avatar w13ear w13ear - test_item - 12 Dec 2015 - Tested successfully
avatar w13ear
w13ear - comment - 12 Dec 2015

I have tested this item :white_check_mark: successfully on acb6002

I have tested this patch succesfully for both Protostar and beez3.
Added an artile with long words in header and content with the expected results.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

avatar Bakual
Bakual - comment - 12 Dec 2015

Same comment here as in other similar PRs. What if the title is built from different words? And where do we have such long words in a title in practice?

avatar superknutsel superknutsel - test_item - 12 Dec 2015 - Tested successfully
avatar superknutsel
superknutsel - comment - 12 Dec 2015

I have tested this item :white_check_mark: successfully on acb6002

@test tested successfully, and yes, a name this long is unlikely. But I found in practice that some customers do not use a space after a comma and therefore create a simmilar effect. Doing something like "bucket,shovel,sand,water,etc" and create the same kind of issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

avatar Bakual
Bakual - comment - 12 Dec 2015

Doing something like "bucket,shovel,sand,water,etc" and create the same kind of issue.

Sounds like the proper fix is then to use a space after a coma :smile:

avatar brianteeman brianteeman - change - 16 Jan 2016
Status Pending Needs Review
avatar brianteeman
brianteeman - comment - 16 Jan 2016

Based on @bakual comments I am setting this to Needs Review for a maintainer to make a decision


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

avatar wilsonge wilsonge - change - 7 May 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 11:26:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 May 2016
avatar wilsonge wilsonge - merge - 7 May 2016
avatar wilsonge wilsonge - reference | db3688f - 7 May 16
avatar wilsonge wilsonge - merge - 7 May 2016
avatar wilsonge wilsonge - close - 7 May 2016
avatar wilsonge wilsonge - change - 7 May 2016
Milestone Added:

Add a Comment

Login with GitHub to post a comment