? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
8 Nov 2015

This PR fixes the layout for long keyword searches in Search Term Analysis in the Isis template

Testing Instructions

Before the PR

Go to Components > Search
Make sure that under [Options] the "Gather Search Statistics" has been switched on to "Yes".
Go to the front-end and search for a really long keyword without spaces and hyphen -
In the back-end go to Components > Search to see that the long keyword searches messes up the layout.

search-term-analysis-wordwrap-isis-before

After the PR

This PR should fix the layout

search-term-analysis-wordwrap-isis-after

avatar pe7er pe7er - open - 8 Nov 2015
avatar pe7er pe7er - change - 8 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2015
Category Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 9 Nov 2015
Easy No Yes
avatar waader waader - test_item - 15 Nov 2015 - Tested successfully
avatar waader
waader - comment - 15 Nov 2015

I have tested this item :white_check_mark: successfully on 007ab3d

Thanks pe7er!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8333.

avatar FeikeMulder FeikeMulder - test_item - 12 Dec 2015 - Tested successfully
avatar FeikeMulder
FeikeMulder - comment - 12 Dec 2015

I have tested this item :white_check_mark: successfully on 007ab3d

tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8333.

avatar Bakual
Bakual - comment - 12 Dec 2015

Same comment here as in other similar PRs. What if the title is built from different words? And where do we have such long words in a title in practice?

avatar superknutsel superknutsel - test_item - 12 Dec 2015 - Tested successfully
avatar superknutsel
superknutsel - comment - 12 Dec 2015

I have tested this item :white_check_mark: successfully on 007ab3d

@test tested succesfull


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8333.

avatar brianteeman brianteeman - change - 16 Jan 2016
Status Pending Needs Review
avatar brianteeman
brianteeman - comment - 16 Jan 2016

Based on @bakual comments I am setting this to Needs Review for a maintainer to make a decision


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8333.

avatar roland-d
roland-d - comment - 7 May 2016

@pe7er Can you please fix the merge conflicts? Thanks.

avatar brianteeman brianteeman - change - 7 May 2016
Status Needs Review Pending
avatar pe7er
pe7er - comment - 7 May 2016

I've created a new PR for this to solve the merge conflict: #10273
Please close this PR.

avatar brianteeman
brianteeman - comment - 7 May 2016

Closed

avatar brianteeman brianteeman - change - 7 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 13:56:45
Closed_By brianteeman
avatar brianteeman brianteeman - close - 7 May 2016

Add a Comment

Login with GitHub to post a comment