? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
7 Nov 2015

More unneeded mootools calls

Testing

On a fresh installation go to global config and make sure that Mouse-over Edit Icons for is set to Modules
Go to the left panel on the modules and select Site

With go to front end and try to edit a module. Try to save it. Everything should function as usual.

There are also 3 more calls for mootools on some modal pages which I don’t have an easy way for testing. BUT by checking the other scripts loaded there and the content of those pages it is obvious that mootools is not required. So request for review on those, unless someone can get some testing instructions...

avatar dgt41 dgt41 - open - 7 Nov 2015
avatar dgt41 dgt41 - change - 7 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 7 Nov 2015

Do we not Need it for B/C or i'm wrong?

avatar dgt41
dgt41 - comment - 7 Nov 2015

No B/C break there. The pages don’t need mootools so they shouldn’t load it. Now if the parent needs to load it with mootool it should load it there otherwise the modal will not work. These are pages that load on a modal so their functionality is pretty defined by the scripts loaded and those script don;t require mootools ????

avatar zero-24
zero-24 - comment - 7 Nov 2015

Great. If i got some time today i Can test it. Thanks

avatar Fedik Fedik - test_item - 7 Nov 2015 - Tested successfully
avatar Fedik
Fedik - comment - 7 Nov 2015

I have tested this item :white_check_mark: successfully on 92eb9b6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8311.

avatar zero-24 zero-24 - test_item - 7 Nov 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 7 Nov 2015

I have tested this item :white_check_mark: successfully on 92eb9b6

Works good. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8311.

avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
Status Pending Ready to Commit
Easy No Yes
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2015
Category JavaScript
avatar zero-24
zero-24 - comment - 7 Nov 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8311.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 10 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-10 22:54:17
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 10 Nov 2015
avatar wilsonge wilsonge - reference | 74e1321 - 10 Nov 15
avatar wilsonge wilsonge - merge - 10 Nov 2015
avatar wilsonge wilsonge - close - 10 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2015
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 18 Nov 2015

Add a Comment

Login with GitHub to post a comment