[#8300] - Fix language keys which trigger wrong plural detection in translation tools
- Closed
- 9 Nov 2015
- Medium
- Build: staging
- Easy Test
- # 8300
- Diff
- Bakual:NonPluralLanguageKeys
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue
While testing Crowdin we found that we have seven language keys in core which are named in a way that triggers plural detection in Crowdin (and probably also other translation tools).
This is because they end with eg "_1". Keys ending directly with a number only are usually used for plural forms.
Solution
This PR deprecates the existing language keys and use new key names for those strings.
According to our rules we don't remove strings within a major series to provide backward compatibility.
Testing
The affected strings are used as options in "Purchase Type" in com_banners component settings, the client and banner forms and the Search Tools in the client manager.
After applying the PR, you should see the english values instead of the translated ones because your language pack doesn't contain a translation (yet) and Joomla will fall back to the english one.
The remaining two are the "Version" parameter in the reCaptcha plugin. However since I doubt that the values are actually different in your language (1.0 likely will be 1.0 as well) you will likely see no difference.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Milestone |
Added: |
||
| Category | ⇒ | Language & Strings |
| Labels | |||
| Easy | No | ⇒ | Yes |
No problem here on review.
I have tested this item 
successfully on 882ea81
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.
| Status | Pending | ⇒ | Ready to Commit |
RTC as 2 tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-09 09:17:14 |
| Closed_By | ⇒ | rdeutz |
wilsonge
- | Labels |
Removed:
?
|
||
I have tested this item
successfully on 882ea81
Works great. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.