[#8281] - JPATH_BASE must be define any way in index.php
- Closed
- 5 Nov 2015
- Medium
- Build: staging
- # 8281
- Diff
- remotehelp:patch-4
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
JPATH_BASE must be define any way. _JDEFINES not need for include defines.php
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
This is actually incorrect. In the override of defines.php you can actually set your own custom JPATH_BASE path which is why the value is only used later if the custom file doesn't exist. I'm therefore going to close this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-05 14:10:11 |
| Closed_By | ⇒ | wilsonge |
@wilsonge You're wrong. Where sense define custom JPATH_BASE? Then site will be broken and joomla update process not will be worked correctly. Also .css and .js from many plurins and modules, whatever, load from root "/" url.
And why define redundant _JDEFINES constant, when you can just use "if(){}else{}" construction? when defines.php must be included in any case!
Please change the title of the PR to reflect what it is. "Update index.php" doesn't say much