Can we fix the unit tests please?

When I try to apply this patch with the patchtester, I always get this message:
Error
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_config/model/form/application.xml

Tried with Hackwar's routing.zip (linked at the top of this page), latest staging, 3.5dev and master branch. Always the the same message.

@Gitjk Please repair your test installation

Just tested again with latest staging branch and my bilingual VM shop. Didn't find any issues. Looks good for me

I have tested this item successfully on a677ef3

Missed the 'Test this' button when I wrote my comment a few minutes ago. In my case the test with latest staging and latest VirtueMart installed (not yet released) is successful.

That is the first time, I have a closer look on the joomla router.
I started with the instructions of issue #5546.
I change the router of com_content by replacing the described texts.
I want to see that the right menu items are still found for the items but I only get the message
Fatal error: Class 'JComponentRouterRulesMenu' not found in E:\Daten\git\joomla-cms\components\com_content\router.php on line 35

I searched for this class myself and I found it in JOOMLA\libraries\cms\component\router\rules\interface.php. I reverted my changes and then I went on with the instructions of #5501, because I am not sure if the instructions in #5546 are obsolete. Are this obsolete?

I checked my site before applying the patch and checked the URLs of com_content.
I apply the patch.
I realized that the URLs of com_content are staying the same. I used the English sample data.
The URL of All Front End Views | Content Component was
was
http://localhost/joomla-cms/index.php/content-component
and is after applying the patch

http://localhost/joomla-cms/index.php/content-component

Then I followed the instructions of #5502
The URL of All Front End Views | Contact Component
was
http://localhost/joomla-cms/index.php/contact-component
and is after applying the patch

http://localhost/joomla-cms/index.php/contact-component

Then I followed the instructions of #5503
The URL of All Front End Views | News Feed Component
was
http://localhost/joomla-cms/index.php/news-feeds-component
and is after applying the patch

http://localhost/joomla-cms/index.php/news-feeds-component

Then I followed the instructions of #5509
The URL of All Front End Views | Users Component
was
http://localhost/joomla-cms/index.php/users-component
and is after applying the patch
http://localhost/joomla-cms/index.php/users-component

I read that the PR #5509 requires #5446 to be accepted by the project before it can be applied. But now the PR #5446 is part of this PR.

With PR #5599 it was the same like PR #5546. I only get the error message: Fatal error: Class 'JComponentRouterRulesMenu' not found in E:\Daten\git\joomla-cms\components\com_content\router.php on line 35. Obsolete Instruction?

I end with the instructions of the PR 5604 where the over-righting ended in a failure message as well. Obsolete Instruction?

Then I went on with testing if the failure of issue #8141 is fixed with this new router.
1. Create a category named "projects"
2. Create a second category named p1 and make it a child of "projects"
3. Create a third category named 1.2.3 and make it a child of p1. Save it with the default alias 1-2.3.
4. Create a menu entry of the List All Categories type and select "projects"
5. Go to the front end of the site and navigate to the new menu entry.
6. Click on it so that you see subcategory p1.
7. Click on p1 so that you see the subcategory 1.2.3.
8. Click on 1.2.3
After activating “Use new URL routing” in the SEO Settings, this failure is fixed.

In the end I installed a small selfmade component and found no issues.

I have tested this item successfully for com_content with a new test installation.

It would though be nice to know the problems solved and known problems remaining.

I found one issue remaining concerning canonical link.

http://localhost/joomla-cms-routing/parks-home/21
canonical:
http://localhost/joomla-cms-routing/article-category-list?id=21

While this gives a correct one.
http://localhost/joomla-cms-routing/parks-home/21-x
canonical
http://localhost/joomla-cms-routing/article-category-list/21-extensions/components/21-getting-help

This probaly comes from the legacyrouter - parse and is not new!
// We check to see if an alias is given. If not, we assume it is an article

Ooops! Forgot to set the parameter to use the new router.
What I wrote above is still valid.
With activated new router the wrong canonical links looks better ;)

http://localhost/joomla-cms-routing/parks-home/21
canonical
http://localhost/joomla-cms-routing/single-article

The page shown is the menu item Parks "Welcome! ... parks of Australia"

If I use this canonical link, I become the single Article of "Welcome! ... parks of Australia"

In other menu items the canonical link points to the menu item itself. Correct.

ie the default to com_content article and/or category has bin removed. Change to the better I believe.

BUG!
Found a bug when scrolling down the page. Below the login module.

3 times the same:
Notice: Undefined index: layout in D:\xampp\htdocs\joomla-cms-routing\libraries\cms\component\router\rules\standard.php on line 212

Check isset?

I'm now trying to test wih a custom component and need some hint for the setup in the router. I tried some variations of the setup for com_content.
I have a main menu (view) that is a "merge" of categories and category. ie nested categories from root to last level. The botttom level has items with links to the item view. normaly shown in the same menuItem.

com_content defines both categories and category, where category is using the categories definition.

Any help and hint?

I have tested this item successfully on a677ef3

Applied with patchester and tested several cases, it is working OK. Is there any additional requirements for testing?

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

Hi folks, I cleaned up the code further, fixed the unittests and fixed the codestyle. Please give this another round of tests.

To test, please apply these changes and enable the new routing in the global configuration. Then check the URLs of the site. The best would be, if you could test this on a copy of a real site. The sampledata of Joomla has already been tested and works. When you test these changes, the URLs should stay the same in most cases. The only time when the URL will be changed by this is when the menu item links to a category and the content item is in a child-child-category of the linked category.

Hi again,
Just had a short (10 Minute) look. Used latest staging Joomla and VirtueMart 3.0.12, both bilingual. After adding #8256 with the patch-tester, I didn't see any difference in urls with 'Use new URL routing' enabled/disabled. Seems to work fine at the first glance. I might have another look on Sunday.

@test
Looks like working fine here on my multilingual test site, sef on.
Did not test the child-child situation yet.

Please alpha order new lang strings.

Tested on a news site, upgraded to Joomla 3.5, installed the new router, crawled Urls with Screaming Frog and compared results. No differences found in resulting Urls.

@Hackwar can you please update this PR to staging (conflicts atm). Got some more people to test on this

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

I've updated the branch. Please notice that I've moved the setting for advanced routing from the global configuration to the component configuration for each specific component.

Merged into 3.6.x branch :)

UsersHelperRoute::getLoginRoute(); is set to deprecated, what's the new call, or are the deprecated tags wrong on the j3.6/7 branch, because on the 4.0 branch its still there

4.0 branch is currently based on staging not the 3.7 branch :)