? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Nov 2015

Steps to reproduce the issue

on a (empty) multilanguage site
administration->contacts->contacts

Actual result

sql error
j35 administration -contacts

After patch

work as expected
j35 administration contacts-f

Comments

wrong group by clause for postgresql,mssql

avatar alikon alikon - open - 3 Nov 2015
avatar alikon alikon - change - 3 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 3 Nov 2015

@alikon is it required to have this ordering or can we move this:

'ul.name' ,
'ul.email',
'l.title' ,
'uc.name' ,
'ag.title' ,

to the top of the group by? (as it was bevor) and than the others above this lines?

avatar alikon
alikon - comment - 3 Nov 2015

unfortunately for strict sql we cannot
cause they are listed in the select clause
..."uc"."name" AS "editor","ag"."title" AS "access_level"...

avatar zero-24
zero-24 - comment - 3 Nov 2015

ok. Also nothing critical as the id (i have not see that bevor) is still on the top ;) I can try testing this later.

avatar zero-24 zero-24 - change - 3 Nov 2015
Category Postgresql
avatar zero-24 zero-24 - change - 3 Nov 2015
Easy No Yes
avatar alikon
alikon - comment - 3 Nov 2015

i've followed the order defined in the SELECT clause

SELECT 
"a"."id","a"."name","a"."alias","a"."checked_out","a"."checked_out_time","a"."catid","a"."user_id","a"."published","a"."access","a"."created","a"."created_by","a"."ordering","a"."featured","a"."language","a"."publish_up","a"."publish_down",
"ul"."name" AS "linked_user",
"ul"."email",
"l"."title" AS "language_title",
"uc"."name" AS "editor",
"ag"."title" AS "access_level","c"."title" AS "category_title" 
avatar waader waader - test_item - 5 Nov 2015 - Tested successfully
avatar waader
waader - comment - 5 Nov 2015

I have tested this item :white_check_mark: successfully on 17da637

Thanks alikon!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8255.

avatar wilsonge wilsonge - change - 5 Nov 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-11-05 14:32:22
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Nov 2015
avatar wilsonge wilsonge - reference | 7cc3c33 - 5 Nov 15
avatar wilsonge wilsonge - merge - 5 Nov 2015
avatar wilsonge wilsonge - close - 5 Nov 2015
avatar wilsonge
wilsonge - comment - 5 Nov 2015

Merged on code review (having done a bunch of these PR's for 3.4 myself :P)

avatar wilsonge wilsonge - change - 5 Nov 2015
Milestone Added:
avatar alikon alikon - head_ref_deleted - 6 Nov 2015

Add a Comment

Login with GitHub to post a comment