? Pending

User tests: Successful: Unsuccessful:

avatar aniket19491
aniket19491
30 Oct 2015

Now you can validate your date and numeric fields.

For e.g
If you have a date field in your Joomla's form and the user enters a wrong date then you will get a fatal error on the page. So its better to validate the date field before saving.

Field 1- YYYY/MM/DD can be validate using class "validate-date"
Field 2- YYYY/MM/DD H:I:S can be validate using class "validate-datetime"

These changes have been added to "validate-uncompressed.js". To test this you will need to minify this file and replace the content of "validate.js" with this.

Let me know if any other information is needed.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar aniket19491 aniket19491 - open - 30 Oct 2015
avatar aniket19491 aniket19491 - change - 30 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 30 Oct 2015

Let me know if any other information is needed.

Can you minify the validate-uncompressed.js file into validate.js with your PR? It will be easyier on merge and test ;)

avatar zero-24 zero-24 - change - 30 Oct 2015
Category JavaScript
avatar aniket19491
aniket19491 - comment - 2 Nov 2015

@zero-24 I have made changes in validate.js too.

avatar datredweb datredweb - test_item - 7 Nov 2015 - Tested unsuccessfully
avatar datredweb
datredweb - comment - 7 Nov 2015

I have tested this item :red_circle: unsuccessfully on e7f4cf8

If i understand the issue right then it is not fixed yet.
Replication steps:

  1. Login to the Admin
  2. Navigate to the Feeds page and create a new Feeds
  3. For the created date field, try to input some "DD/MM/YYYY", different than current date.
  4. Save it, it still works.
  5. Open the Feed again

Observe: The date is automatically transformed to a current date
Expect: We should validate the date format on the inputting steps when user trying to create a new Feed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8208.

avatar aniket19491
aniket19491 - comment - 9 Nov 2015

@datredweb Thank you for testing.

Have you added the class "validate-date" or "validate-datetime" to that date input field? It won't work without adding the validate class.

avatar brianteeman brianteeman - change - 10 Mar 2016
Category JavaScript Fields JavaScript
avatar brianteeman
brianteeman - comment - 8 May 2016

I can see what you are doing here but as it is it is not ready for inclusion in the core. If you can look at how to implement validation on the date fields in the core joomla fields we can always re-open it when it is ready for testing again.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8208.

avatar brianteeman brianteeman - close - 8 May 2016
avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 13:06:24
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 May 2016
avatar parthlawate
parthlawate - comment - 9 May 2016

I think it should be kept open. Maybe tested via a different test case. Since this is more like a library fix which allows for new validations ..

Now that it's available it can be used in various parts of the Joomla core ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8208.

avatar brianteeman
brianteeman - comment - 9 May 2016

Provide the method for testing then

avatar parthlawate
parthlawate - comment - 9 May 2016

OK.. Will ask one of the team to Submit another PR to implement this in one of the Standard Joomla forms so that the test case can be provided. And provide that link here as well.

Add a Comment

Login with GitHub to post a comment