Joomla! Issue Tracker | Joomla! CMS #8179 - Convert IDNA_Convert library to be Composer managed, update to 0.9

? ? ?

Closed
30 Oct 2015
Medium
Build: staging
Easy Test
# 8179
Diff
mbabker:Composer-IDNA

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

mbabker
27 Oct 2015

This is a resubmit of #7552

This PR moves the IDNA_Convert library from a Joomla library extension to being managed via Composer (using https://github.com/phpWhois/idna-convert as the source). It also runs an update to version 0.9 of the library and restores the accidentally deleted test class for our Punycode conversions (only affects the 3.5 branch).

Testing

With the patch applied, things should still work as intended. Details from JM on the original issue:

e-mail fields and urls fields.
Basically for example:
Entering in the field: http://www.джумла-тест.рф/master
will be saved in the db as:
http://www.xn----7sblgc4ag8bhcd.xn--p1ai/master
and will still display in the field as:
http://www.джумла-тест.рф/master

When it is used in a page, it is the punycoded version stored in the db which is used as url link or mailto.
So we will see:

but the source will be:

        <span class="contact-webpage">
            <a href="http://www.xn----7sblgc4ag8bhcd.xn--p1ai/master" target="_blank" itemprop="url">
            http://www.джумла-тест.рф/master</a>
        </span>