User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I am trying to do that now.
Labels |
Added:
?
|
Category | ⇒ | Administration |
This PR has received new commits.
CC: @bertmert
CC: @adhocgraFX, @christianhent, @designbengel, @KingLouis1, @RoterNagel, @Yorgoz
Please test.
This PR has received new commits.
@test
I confirm. Test OK
Category | Administration | ⇒ | Administration Libraries |
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Labels |
Milestone |
Added: |
RTC for 3.5.0. Thanks
Labels |
Added:
?
|
@infograf768 I like it a lot but I think if we go for a light colored tool tip we should apply some shadow around it (same as modal, popup, menus)
So here is a preview of that:
And the changes:
jui/tooltip.less after line 5
// Base class
.tooltip {
position: absolute;
z-index: @zindexTooltip;
display: block;
visibility: visible;
font-size: 11px;
line-height: 1.4;
.opacity(0);
.border-radius(@baseBorderRadius);
&.in { .opacity(80); }
&.top { margin-top: -3px; padding: 0px 0; }
&.right { margin-left: 3px; padding: 0 5px; }
&.bottom { margin-top: 3px; padding: 0px 0; }
&.left { margin-left: -3px; padding: 0 5px; }
}
and isis/template.less after line 1048
.box-shadow(0 0 5px rgba(0,0,0,0.3));
Same thing for protostar
@infograf768 Would you like to add @dgt41 suggestion to this PR?
Pleaase contact me on glip
@infograf768 Fine by me, then I will merge this as-is.
You guys are aware that Bootstrap already has a thing called "Popover" which would look exactly like that? See http://getbootstrap.com/2.3.2/javascript.html#popovers
Bootstrap tooltips aren't meant to contain a title or lengthy texts, that's what popver are designed for. The JS is the same, just a difference in appearance.
Would not changing from tooltip to popovers be much more complex and maybe not B/C?
See #8174 for an idea how to use Popovers. You will see that they look about the same to what you try to do here.
So you basically remove tooltips from backend and make everything a popover.
The main issue is however that we did misuse tooltips back when we started using Bootstrap tooltips. They were never meant to show titles to begin with. We hacked around it instead of using the proper method
Folks, I succeeded in patching also Hathor, Beez and Protostar, but, doing so, I found out that this PR is not B/C at all for the other templates around because of the change in the library.
I.e. any template not updating their css will not get any more the tooltip title in bold and will keep the background colour and text colour the template maker has set.
I guess therefore that it is not the solution. Commented on @Bakual suggestion in #8174 (comment)
Milestone |
Removed: |
||
Status | Ready to Commit | ⇒ | Pending |
Labels |
Milestone |
Removed: |
Ok so for now we remove the milestone and label.
Labels |
Removed:
?
|
I have tested this item successfully on 142ce1e
This PR has received new commits.
CC: @bertmert, @designbengel, @fontanil
In case of, I also took care of Hathor, Beez and Protostar.
To test with English and an RTL language.
Even if I don't know if this PR is still relevant.
@test Tested successfully with all core templates BE and FE
Concerning BC and STRONG. The main conflict in the beginning was that STRONG was formatted as block. This has been removed now and .tooltip-title is block now.
So, I think changing line https://github.com/joomla/joomla-cms/pull/8150/files#diff-b01d47e3fbe4a8e5fb4987f4df64b291R920
to
$result = '<span class="tooltip-title"><strong>' . $title . '</strong></span>';
or
$result = '<span class="tooltip-title"><b>' . $title . '</b></span>';
could be a solution for BC
@infograf768 I'm a bit confused on the status of this PR
Status | Pending | ⇒ | Information Required |
Labels |
I guess this PR is no longer needed.
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 15:25:31 |
Closed_By | ⇒ | brianteeman |
Labels |
Travis is failing here :( maybe because of different html?