? ? Success
Referenced as Related to: # 8174

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
25 Oct 2015

See #6050

This solves the <strong> issue.

After patch (clear your caches) you should get:
screen shot 2015-10-25 at 09 31 25
screen shot 2015-10-25 at 10 16 01
screen shot 2015-10-25 at 10 16 28

avatar infograf768 infograf768 - open - 25 Oct 2015
avatar infograf768 infograf768 - change - 25 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 25 Oct 2015

Travis is failing here :( maybe because of different html?

avatar roland-d
roland-d - comment - 25 Oct 2015

@zero-24 Indeed, the unit tests fail due to the changed HTML. The unit test should be updated as well to reflect the change in HTML.

avatar infograf768
infograf768 - comment - 25 Oct 2015

I am trying to do that now.

avatar bertmert
bertmert - comment - 25 Oct 2015

@test Successfully tested with ISIS and current staging. :white_check_mark:

avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?
avatar infograf768 infograf768 - change - 25 Oct 2015
Category Administration
avatar infograf768 infograf768 - alter_testresult - 25 Oct 2015 - bertmert: Tested successfully
avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Oct 2015

This PR has received new commits.

CC: @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar infograf768
infograf768 - comment - 26 Oct 2015
avatar fontanil
fontanil - comment - 26 Oct 2015

@test
Patch is OK. Thanks!

avatar infograf768 infograf768 - alter_testresult - 26 Oct 2015 - fontanil: Tested successfully
avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Oct 2015

This PR has received new commits.

CC: @bertmert, @fontanil


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar infograf768
infograf768 - comment - 26 Oct 2015

@bertmert
Although we do not need to escape single quotes when using JText it does not cost much to do so in this precise context. Modified PR.

avatar infograf768
infograf768 - comment - 26 Oct 2015

@bertmert, @fontanil
Please retest and confirm on issues.joomla.org + test also
#8161

thanks

avatar fontanil
fontanil - comment - 26 Oct 2015

@test
I confirm. Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar infograf768 infograf768 - alter_testresult - 26 Oct 2015 - fontanil: Tested successfully
avatar infograf768 infograf768 - change - 26 Oct 2015
Category Administration Administration Libraries
avatar bertmert
bertmert - comment - 26 Oct 2015

@test Tested successfully :white_check_mark: this PR in combination with #8161

avatar zero-24 zero-24 - alter_testresult - 26 Oct 2015 - bertmert: Tested successfully
avatar zero-24 zero-24 - change - 26 Oct 2015
Milestone Added:
Status Pending Ready to Commit
Labels
avatar zero-24 zero-24 - change - 26 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 26 Oct 2015

RTC for 3.5.0. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Added: ?
avatar dgt41
dgt41 - comment - 26 Oct 2015

@infograf768 I like it a lot but I think if we go for a light colored tool tip we should apply some shadow around it (same as modal, popup, menus)
So here is a preview of that:
screenshot 2015-10-26 16 17 19
And the changes:
jui/tooltip.less after line 5

// Base class
.tooltip {
  position: absolute;
  z-index: @zindexTooltip;
  display: block;
  visibility: visible;
  font-size: 11px;
  line-height: 1.4;
  .opacity(0);
  .border-radius(@baseBorderRadius);
  &.in     { .opacity(80); }
  &.top    { margin-top:  -3px; padding: 0px 0; }
  &.right  { margin-left:  3px; padding: 0 5px; }
  &.bottom { margin-top:   3px; padding: 0px 0; }
  &.left   { margin-left: -3px; padding: 0 5px; }
}

and isis/template.less after line 1048

  .box-shadow(0 0 5px rgba(0,0,0,0.3));

Same thing for protostar

avatar roland-d
roland-d - comment - 27 Oct 2015

@infograf768 Would you like to add @dgt41 suggestion to this PR?

avatar infograf768
infograf768 - comment - 27 Oct 2015

@dgt41

Pleaase contact me on glip


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar infograf768
infograf768 - comment - 27 Oct 2015

@roland-d
I tested @dgt41 suggestion and It's missing something here.
Concerning Protostar, I suggest to do a separate PR

avatar roland-d
roland-d - comment - 27 Oct 2015

@infograf768 Fine by me, then I will merge this as-is.

avatar infograf768
infograf768 - comment - 27 Oct 2015

@roland-d
Please wait I talked to @dgt41

avatar Bakual
Bakual - comment - 27 Oct 2015

You guys are aware that Bootstrap already has a thing called "Popover" which would look exactly like that? See http://getbootstrap.com/2.3.2/javascript.html#popovers
Bootstrap tooltips aren't meant to contain a title or lengthy texts, that's what popver are designed for. The JS is the same, just a difference in appearance.

avatar infograf768
infograf768 - comment - 27 Oct 2015

Would not changing from tooltip to popovers be much more complex and maybe not B/C?

avatar infograf768
infograf768 - comment - 27 Oct 2015

@dgt41
After some modifications to your proposal, I can obtain this:
screen shot 2015-10-27 at 09 28 00

@Bakual
If you have a better idea, please propose some code.

avatar Bakual
Bakual - comment - 27 Oct 2015

See #8174 for an idea how to use Popovers. You will see that they look about the same to what you try to do here.
So you basically remove tooltips from backend and make everything a popover.

The main issue is however that we did misuse tooltips back when we started using Bootstrap tooltips. They were never meant to show titles to begin with. We hacked around it instead of using the proper method :smile:

avatar infograf768
infograf768 - comment - 27 Oct 2015

Folks, I succeeded in patching also Hathor, Beez and Protostar, but, doing so, I found out that this PR is not B/C at all for the other templates around because of the change in the library.
I.e. any template not updating their css will not get any more the tooltip title in bold and will keep the background colour and text colour the template maker has set.

I guess therefore that it is not the solution. Commented on @Bakual suggestion in #8174 (comment)

avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Removed:
Status Ready to Commit Pending
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Milestone Removed:
avatar zero-24
zero-24 - comment - 27 Oct 2015

Ok so for now we remove the milestone and label.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Removed: ?
avatar designbengel designbengel - test_item - 27 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 27 Oct 2015

I have tested this item :white_check_mark: successfully on 142ce1e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Oct 2015

This PR has received new commits.

CC: @bertmert, @designbengel, @fontanil


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar infograf768
infograf768 - comment - 27 Oct 2015

In case of, I also took care of Hathor, Beez and Protostar.
To test with English and an RTL language.

avatar bertmert
bertmert - comment - 13 Nov 2015

Even if I don't know if this PR is still relevant.
@test Tested successfully with all core templates BE and FE

Concerning BC and STRONG. The main conflict in the beginning was that STRONG was formatted as block. This has been removed now and .tooltip-title is block now.

So, I think changing line https://github.com/joomla/joomla-cms/pull/8150/files#diff-b01d47e3fbe4a8e5fb4987f4df64b291R920

to

$result = '<span class="tooltip-title"><strong>' . $title . '</strong></span>';

or

$result = '<span class="tooltip-title"><b>' . $title . '</b></span>';

could be a solution for BC

avatar bertmert
bertmert - comment - 14 Nov 2015

Found another issue with Hathor (not directly related to the changes of this patch but also same behavior with this patch).
#8434

avatar brianteeman
brianteeman - comment - 27 Jan 2016

@infograf768 I'm a bit confused on the status of this PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar brianteeman brianteeman - change - 2 May 2016
Status Pending Information Required
Labels
avatar brianteeman
brianteeman - comment - 8 May 2016

I guess this PR is no longer needed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8150.

avatar brianteeman brianteeman - change - 8 May 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 15:25:31
Closed_By brianteeman
avatar brianteeman brianteeman - change - 8 May 2016
Labels

Add a Comment

Login with GitHub to post a comment