? Success
Pull Request for # 6998

User tests: Successful: Unsuccessful:

avatar sudo-web
sudo-web
25 Oct 2015

Additional support, to help user by autocompleting there email address in requested forms.
Fully supports the "autocomplete" attribute for form fields according to the current WHATWG HTML Standard.
Informational link to that topic:
http://googlewebmastercentral.blogspot.ru/2015/03/helping-users-fill-out-online-forms.html
Added attribute to email address field on the following forms:
com_contact : contact
com_user : registration, profile , remind

avatar sudo-web sudo-web - open - 25 Oct 2015
avatar sudo-web sudo-web - change - 25 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Oct 2015
Category Front End UI/UX
avatar zero-24 zero-24 - change - 25 Oct 2015
Easy No Yes
avatar sudo-web
sudo-web - comment - 26 Oct 2015

Hey folks,
How do I get a (this) pull request merged to an existing issue?
In this case to #6998


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar zero-24 zero-24 - change - 26 Oct 2015
Rel_Number 0 6998
Relation Type Pull Request for
avatar zero-24
zero-24 - comment - 26 Oct 2015

Just done @sudo-web ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar sudo-web
sudo-web - comment - 26 Oct 2015

@zero-24 do I see it right, a merge or to create a pull request that is already linked to an existing issue could not done by myself?
I didn’t find any documentation to that question, that not includes the hub command and I'm not sure if that works in our case


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar zero-24
zero-24 - comment - 26 Oct 2015

@sudo-web you don't need to merge something ;) If you fix a issue you just need to add a link on that issue to your pull request. Than a Maintainer can close the issue with referece to your pull :smile:

avatar waader waader - test_item - 5 Nov 2015 - Tested successfully
avatar waader
waader - comment - 5 Nov 2015

I have tested this item :white_check_mark: successfully on 8d5f65a

Thanks sudo-web!

Is there a reason why you have omitted reset_request.xml or email2 in profile.xml and registration.xml?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar sudo-web
sudo-web - comment - 5 Nov 2015

It is security vs comfort.
I thought, that this are the cases where I really want the user to fill in the fields.
So the first email goes with autocomplete but the second has to be filled in by the user.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar waader
waader - comment - 5 Nov 2015

I thought something along those lines.

avatar anibalsanchez
anibalsanchez - comment - 6 Nov 2015

Test OK - autocomplete="email" is added in modified forms.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar anibalsanchez anibalsanchez - test_item - 6 Nov 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 6 Nov 2015

I have tested this item :white_check_mark: successfully on 8d5f65a

Test OK - autocomplete="email" is added in modified forms.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar zero-24 zero-24 - change - 6 Nov 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 6 Nov 2015

RTC thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-16 20:24:26
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 16 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment