[#8147] - Add access checks to the plugin parameter
- Closed
- 19 Dec 2015
- Medium
- Build: staging
- Easy Test
- # 8147
- Diff
- bembelimen:patch-10
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
At the moment every user gets the same tinyMCE button structure, regardless of his/her permissions/access level.
With this patch, all buttons from the complete mode can be linked to an access level, so you can customise the editor by access level.
Test:
- Set the editor mode to "complete"
- Apply patch => editor should work as before (so no B/C issues)
- Look into the editor parameters, here you can now define access levels on the second tab
- Play with the different combinations and see how the editor buttons change
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I also fixed the missspelled "colour => color"
I have tested this item 
successfully on 2bd8ed6
Works good here.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Category | ⇒ | ACL Plugins |
Just marked as new feature for 3.5.0 looks great to me.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
maybe we need to update the description as well? Currently we have there: Something like Turn on/off to enable the alignment of the text. Only works in Extended mode.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
I have tested this item successfully on 2bd8ed6
While the patch works as advertised, I aggree that the language strings should be changed as well.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
YES! Thanks @bembelimen. Looks like tinyMCE is set to regain it’s lost reputation…
@test OK
@bembelimen, @zero-24, @dgt41 I would like to hear your opinion on whether it is a good idea to change all language strings for the affected fields or just extend the following message to e.g.
Extended Mode Options
Below you can set the access level for each one of the fields individually.
Please keep in mind that these options will only have an effect in Extended mode.
On second thought I'd like to change all message and even remove the redundant "Only applies / works in Extended mode" suffix. What do you think?
I like the idea of removing "only applies..." on each field with the extended headline. But I'm not sure, if you can leave the other description on every field:
"Turn on/off..." e.g.
@matrikular the three levels (basic, advance and extended) was a way to get different levels of permission (also served as a way to quickly setup the editor) to user needs. With this PR this is totally useless and what would make sense is to restructure the plugin so each plugin and button can be assigned to certain access level. But then again that would break B/C?
Now about the strings I would go with a single field note with the text you provided above, the easiest solution...
To make the other levels useless, we have to add the permissions to every button. But yeah, if we do that, it will totaly breaks B/C and this feature will come not before 4.x.
The future plan is to do exactly this, but I want the first step in 3.5, so we have to take care of B/C.
If this PR will be accepted, I'll try to extend the plugin to support all buttons and (perhaps) move them on the toolbar (for J! 4.x)
This PR has received new commits.
CC: @dgt41, @matrikular, @zero-24
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
| Labels |
Added:
?
|
||
@matrikular improved and fixed the language strings.
Thank you
This PR has received new commits.
CC: @dgt41, @matrikular, @zero-24
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
@bembelimen can you rebase this one to 3.5-dev? The code for tinymce.php is a lot different is the two repos (staging and 3.5-dev). I would test it immediately!
@bembelimen Forget my last comment
@test ok
I have tested this item successfully on 30adc4a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
| Status | Pending | ⇒ | Ready to Commit |
@bembelimen can you resync it, as it got conflicts right now?
| Labels |
Added:
?
|
||
It shouldn't be rebased to 3.5-dev as we only use staging now. Only need the conflicts merged and we are ready to merge.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 13:10:48 |
| Closed_By | ⇒ | Kubik-Rubik |
Thank you @bembelimen and testers. Solved conflicts and merged with b269c7b!
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 2015-11-04 13:10:48 | ⇒ | 2015-12-19 10:51:57 |
| Closed_By | Kubik-Rubik | ⇒ | brianteeman |
| Labels | |||
| Status | Closed | ⇒ | New |
| Closed_Date | 2015-12-19 10:51:57 | ⇒ | |
| Closed_By | brianteeman | ⇒ | |
| Labels | |||
This was merged - looks like the tracker didnt close
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
Stupid bot
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8147.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-19 10:55:51 |
| Closed_By | ⇒ | infograf768 |
| Status | Fixed in Code Base | ⇒ | Closed |
| Closed_By | infograf768 | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/8147
| Status | Closed | ⇒ | New |
| Closed_Date | 2015-12-19 10:55:51 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
hmm
CLOSED!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-19 16:56:19 |
| Closed_By | ⇒ | joomla-cms-bot |
@zero-24 yep, I used the original Joomla! header (from 3.4.5), so yeah, I reverted it. Thanks