User tests: Successful: Unsuccessful:
This PR is a replacement for "com_plugin - Moved Filters from sidebar to Search Tools #7699".
This PR will move the filters from sidebar to Search Tools
and adds Ordering + Direction dropdown options to Search Tools area.
Please use testing procedure of #7699
Note: the click-on-column-ordering does not work anymore. If someone spots the cause of that issue, please help me to correct it. Thanks!
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Administration UI/UX |
Easy | No | ⇒ | Yes |
I have tested this item successfully on f785e1a
I tested it again sucessfully
I have tested this item successfully on f785e1a
Tested successful, ordering works. BTW Question: Why do we have everywhere - Select status - which shows "all" and additionally "All" - wouldn´t it be easier to have a "All Status" for select label ?
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Milestone |
Added: |
RTC.
@committer please have a look into the comment by @pe7er bevor committing.
Note: the click-on-column-ordering does not work anymore. If someone spots the cause of that issue, please help me to correct it. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.
Labels |
Added:
?
|
And the comment by @designbengel as well ;)
Status | Ready to Commit | ⇒ | Pending |
Labels |
Labels |
Labels |
Removed:
?
|
Thanks @roland-d.
Now the column ordering is working again
But the Ordering & Direction dropdown are not working anymore.
I tried to add the following to the populateState method but that did not work either:
$ordering = $this->getUserStateFromRequest($this->context . '.list.ordering', 'list_ordering', '', 'cmd');
$this->setState('list.ordering', $ordering);
what have you meant with column ordering? because on my site i thought it worked - but maybe i meant something else :)
Sorry for the confusion. With Column Ordering, I mean that clicking on the Column headers will order the results: {Ordering}, Status, Plugin Name, Type, Element, Access, ID (like it's currently working without this PR).
The dropdown boxes on the top right "Sort Table By" & "select the ordering" are not working anymore.
Technical background info:
Now the dropdown ordering & column header ordering are synchronized. If you click on a column header, the ordering dropdown should take over the same ordering value as the column header, and the direction dropdown box too.
Huge thanks to @roland-d for helping me out with the JavaScript code needed to accomplish this.
This PR has received new commits.
CC: @designbengel, @jduerscheid
This PR has received new commits.
CC: @designbengel, @jduerscheid
This PR has received new commits.
CC: @designbengel, @jduerscheid
This PR has received new commits.
CC: @designbengel, @jduerscheid
Labels |
Added:
?
|
This PR has received new commits.
CC: @designbengel, @jduerscheid
nonumber:
Wasn't the whole idea to move away from the Search Tools and use the side bar instead?
#7699 (comment)compojoom:
@nonumber - that's what I'm wondering as well. Do we have a "design guide" or something? It would be stupid to have the filters once in search tools, then on the right. We should decide what we want to use and then stick to it.
#7699 (comment)
This PR has received new commits.
CC: @designbengel, @jduerscheid
Restarted Travis checks.
I have tested this item successfully on 45f7cb1
I would change the class for the pagination to class="pagination pagination-toolbar center"
to get it centered, now is is left aligned. weird...
Travis checks fails here: https://travis-ci.org/joomla/joomla-cms/jobs/89131184
This PR has received new commits.
CC: @designbengel, @dgt41, @jduerscheid
This PR has received new commits.
CC: @designbengel, @dgt41, @jduerscheid
Labels |
Removed:
?
|
I have tested this item successfully on f29115d
Looks like I'm being ignored again (like in the other PR)
So again:
@nonumber :
Wasn't the whole idea to move away from the Search Tools and use the side bar instead?
#7699 (comment)@compojoom :
@nonumber - that's what I'm wondering as well. Do we have a "design guide" or something? It would be stupid to have the filters once in search tools, then on the right. We should decide what we want to use and then stick to it.
#7699 (comment)
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 23:56:10 |
Closed_By | ⇒ | roland-d |
As far as I know, Search Tools are more advanced than the filters in the left sidebar:
Imho I think the aim in this release has been to move things into search tools as per your guys code sprint for J3.2 (which only ever got half implemented in the CMS at that point). I think pretty much all the core components now use search tools as of 3.5
ok
@pe7er travis is failing here?