? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
24 Oct 2015

This PR is a replacement for "com_plugin - Moved Filters from sidebar to Search Tools #7699".

This PR will move the filters from sidebar to Search Tools
and adds Ordering + Direction dropdown options to Search Tools area.
Please use testing procedure of #7699

com_plugins_filter_odering

Note: the click-on-column-ordering does not work anymore. If someone spots the cause of that issue, please help me to correct it. Thanks!

avatar pe7er pe7er - open - 24 Oct 2015
avatar pe7er pe7er - change - 24 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 24 Oct 2015

@pe7er travis is failing here?

avatar pe7er
pe7er - comment - 24 Oct 2015

@zero-24 No, I was failing regarding code style and of course Travis was not happy with that ;-)

avatar zero-24 zero-24 - change - 24 Oct 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 24 Oct 2015
Easy No Yes
avatar jduerscheid jduerscheid - test_item - 26 Oct 2015 - Tested successfully
avatar jduerscheid
jduerscheid - comment - 26 Oct 2015

I have tested this item :white_check_mark: successfully on f785e1a

I tested it again sucessfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar designbengel designbengel - test_item - 27 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 27 Oct 2015

I have tested this item :white_check_mark: successfully on f785e1a

Tested successful, ordering works. BTW Question: Why do we have everywhere - Select status - which shows "all" and additionally "All" - wouldn´t it be easier to have a "All Status" for select label ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 27 Oct 2015

RTC.

@committer please have a look into the comment by @pe7er bevor committing.

Note: the click-on-column-ordering does not work anymore. If someone spots the cause of that issue, please help me to correct it. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 27 Oct 2015

And the comment by @designbengel as well ;)

avatar roland-d
roland-d - comment - 27 Oct 2015

@pe7er I commented on where it breaks. You may want to check if both filters can set the same value, so you don't need to change the model but just the template file. My 2ct.

avatar zero-24 zero-24 - change - 27 Oct 2015
Status Ready to Commit Pending
Labels
avatar pe7er pe7er - change - 28 Oct 2015
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2015
Labels Removed: ?
avatar pe7er
pe7er - comment - 28 Oct 2015

Thanks @roland-d.
Now the column ordering is working again

But the Ordering & Direction dropdown are not working anymore.

I tried to add the following to the populateState method but that did not work either:

$ordering = $this->getUserStateFromRequest($this->context . '.list.ordering', 'list_ordering', '', 'cmd');
$this->setState('list.ordering', $ordering);
avatar designbengel
designbengel - comment - 28 Oct 2015

what have you meant with column ordering? because on my site i thought it worked - but maybe i meant something else :)

avatar pe7er
pe7er - comment - 28 Oct 2015

Sorry for the confusion. With Column Ordering, I mean that clicking on the Column headers will order the results: {Ordering}, Status, Plugin Name, Type, Element, Access, ID (like it's currently working without this PR).

The dropdown boxes on the top right "Sort Table By" & "select the ordering" are not working anymore.

Technical background info:

  • I removed the code for the 3 boxes (Ordering, Direction & List Limit) from the view (/administrator/components/com_plugins/views/plugins/tmpl/default.php).
  • I added the functionality to the Search Tools (/administrator/components/com_plugins//models/forms/filter_plugins.xml)
  • However, I cannot get the status of the "Sort Table By" & "select the ordering" dropdown boxes to work correctly in the _getList method.
avatar pe7er
pe7er - comment - 28 Oct 2015

With help from @roland-d (thanks!) I fixed the dropdown boxes on the top right "Sort Table By" & "select the ordering". Thanks Roland!

avatar pe7er
pe7er - comment - 29 Oct 2015

Now the dropdown ordering & column header ordering are synchronized. If you click on a column header, the ordering dropdown should take over the same ordering value as the column header, and the direction dropdown box too.

Huge thanks to @roland-d for helping me out with the JavaScript code needed to accomplish this.

avatar joomla-cms-bot
joomla-cms-bot - comment - 29 Oct 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Nov 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Nov 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Nov 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 3 Nov 2015

Thanks @roland-d for unit test correction!

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Nov 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar pe7er
pe7er - comment - 3 Nov 2015

Thanks @wilsonge for the correction to fix unit test error!

avatar nonumber
nonumber - comment - 3 Nov 2015

nonumber:
Wasn't the whole idea to move away from the Search Tools and use the side bar instead?
#7699 (comment)

compojoom:
@nonumber - that's what I'm wondering as well. Do we have a "design guide" or something? It would be stupid to have the filters once in search tools, then on the right. We should decide what we want to use and then stick to it.
#7699 (comment)

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Nov 2015

This PR has received new commits.

CC: @designbengel, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar Kubik-Rubik
Kubik-Rubik - comment - 4 Nov 2015

Restarted Travis checks.

avatar dgt41 dgt41 - test_item - 4 Nov 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on 45f7cb1

I would change the class for the pagination to class="pagination pagination-toolbar center" to get it centered, now is is left aligned. weird...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar zero-24
zero-24 - comment - 4 Nov 2015
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Nov 2015

This PR has received new commits.

CC: @designbengel, @dgt41, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Nov 2015

This PR has received new commits.

CC: @designbengel, @dgt41, @jduerscheid


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar pe7er
pe7er - comment - 4 Nov 2015

Thanks for the corrections @wilsonge!

avatar roland-d roland-d - change - 4 Nov 2015
Labels Removed: ?
avatar pe7er
pe7er - comment - 4 Nov 2015

Thanks for testing @dgt41
I think that the class="pagination pagination-toolbar center" can be added with separate PR?

avatar designbengel designbengel - test_item - 4 Nov 2015 - Tested successfully
avatar designbengel
designbengel - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on f29115d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8146.

avatar dgt41
dgt41 - comment - 4 Nov 2015

@test ok here as well.
@pe7er probably we have to align all the backend pagination either to left or to the center and stick to that rule…

avatar nonumber
nonumber - comment - 4 Nov 2015

Looks like I'm being ignored again (like in the other PR)
So again:

@nonumber :
Wasn't the whole idea to move away from the Search Tools and use the side bar instead?
#7699 (comment)

@compojoom :
@nonumber - that's what I'm wondering as well. Do we have a "design guide" or something? It would be stupid to have the filters once in search tools, then on the right. We should decide what we want to use and then stick to it.
#7699 (comment)

avatar roland-d roland-d - change - 4 Nov 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-11-04 23:56:10
Closed_By roland-d
avatar roland-d roland-d - close - 4 Nov 2015
avatar roland-d roland-d - close - 4 Nov 2015
avatar pe7er
pe7er - comment - 4 Nov 2015

As far as I know, Search Tools are more advanced than the filters in the left sidebar:

  • you can clear all filters with just one one click on "Clear",
  • better separation of HTML output & function: the filters are defined in /models/forms/filter_somename.xml and not within the HTML of the default.php layout file.
avatar wilsonge
wilsonge - comment - 5 Nov 2015

Imho I think the aim in this release has been to move things into search tools as per your guys code sprint for J3.2 (which only ever got half implemented in the CMS at that point). I think pretty much all the core components now use search tools as of 3.5

avatar nonumber
nonumber - comment - 5 Nov 2015

ok

avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment